[CodeQuality] Handle do { } while maybe returned on ExplicitReturnNul…

…lRector (#5766)

* [CodeQuality] Handle do {} while maybe returned on ExplicitReturnNullRector

* handle possibly returned

* debug

* debug

rules-tests/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector/Fixture/do_while_maybe_returned.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+final class DoWhileMaybeReturned
+{
+    public function run(int $i)
+    {
+		do {
+			if (rand(0, 1)) {
+				continue;
+			}
+
+			return 2;
+		} while (++$i < 1);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+final class DoWhileMaybeReturned
+{
+    public function run(int $i)
+    {
+		do {
+			if (rand(0, 1)) {
+				continue;
+			}
+
+			return 2;
+		} while (++$i < 1);
+  return null;
+    }
+}
+
+?>

rules-tests/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector/Fixture/do_while_maybe_returned2.php.inc

@@ -0,0 +1,40 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+final class DoWhileMaybeReturned2
+{
+    public function run(int $i)
+    {
+		do {
+    		if (rand(0,1)) {
+                break;
+    		}
+
+		    return 2;
+		} while (++$i < 1);
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+final class DoWhileMaybeReturned2
+{
+    public function run(int $i)
+    {
+		do {
+    		if (rand(0,1)) {
+                break;
+    		}
+
+		    return 2;
+		} while (++$i < 1);
+  return null;
+    }
+}
+
+?>

rules/TypeDeclaration/TypeInferer/SilentVoidResolver.php

@@ -13,7 +13,9 @@
 use PhpParser\Node\Expr\YieldFrom;
 use PhpParser\Node\FunctionLike;
 use PhpParser\Node\Stmt;
+use PhpParser\Node\Stmt\Break_;
 use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\Node\Stmt\Continue_;
 use PhpParser\Node\Stmt\Do_;
 use PhpParser\Node\Stmt\Else_;
 use PhpParser\Node\Stmt\Expression;
@@ -94,14 +96,26 @@ private function hasStmtsAlwaysReturnOrExit(array $stmts): bool
                 return true;
             }
 
-            if ($stmt instanceof Do_ && $this->hasStmtsAlwaysReturnOrExit($stmt->stmts)) {
+            if ($stmt instanceof Do_ && $this->isDoWithAlwaysReturnOrExit($stmt)) {
                 return true;
             }
         }
 
         return false;
     }
 
+    private function isDoWithAlwaysReturnOrExit(Do_ $do): bool
+    {
+        if (! $this->hasStmtsAlwaysReturnOrExit($do->stmts)) {
+            return false;
+        }
+
+        return ! (bool) $this->betterNodeFinder->findFirst(
+            $do->stmts,
+            static fn (Node $node): bool => $node instanceof Break_ || $node instanceof Continue_
+        );
+    }
+
     private function isIfReturn(Stmt|Expr $stmt): bool
     {
         if (! $stmt instanceof If_) {