ExplicitMethodCallOverMagicGetSetRector fix (#2719)

rectorphp · Jul 28, 2022 · 8df7912 · 8df7912
1 parent ec9c15a
commit 8df7912
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/...opertyFetch/ExplicitMethodCallOverMagicGetSetRector/Fixture/skip_unknown_property.php.inc b/...opertyFetch/ExplicitMethodCallOverMagicGetSetRector/Fixture/skip_unknown_property.php.inc
@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\PropertyFetch\ExplicitMethodCallOverMagicGetSetRector\Fixture;
+
+use Rector\Tests\CodeQuality\Rector\PropertyFetch\ExplicitMethodCallOverMagicGetSetRector\Source\ObjectWithMagicCalls;
+
+final class SomeClass
+{
+    public function run(ObjectWithMagicCalls $magicObject)
+    {
+        return $magicObject->unknown;
+    }
+}
+
+?>
+
diff --git a/rules/CodeQuality/Rector/PropertyFetch/ExplicitMethodCallOverMagicGetSetRector.php b/rules/CodeQuality/Rector/PropertyFetch/ExplicitMethodCallOverMagicGetSetRector.php
@@ -150,6 +150,10 @@ private function refactorPropertyFetch(PropertyFetch $propertyFetch, Scope $scop
             return null;
         }
 
+        if (! $callerType->hasProperty($propertyName)->yes()) {
+            return null;
+        }
+
         $propertyReflection = $callerType->getProperty($propertyName, $scope);
         $propertyType = $propertyReflection->getReadableType();