[CodeQuality] Handle crash on variable variable on assign closure on …

…OptionalParametersAfterRequiredRector (#5089)

* [CodeQuality] Handle crash on variable variable on assign closure on OptionalParametersAfterRequiredRector

* Fix

* Fix scope check

packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

@@ -197,7 +197,7 @@ public function processNodes(
 
         $nodeTraverser = new NodeTraverser();
         $nodeTraverser->addVisitor(new WrappedNodeRestoringNodeVisitor());
-        $nodeTraverser->addVisitor(new ExprScopeFromStmtNodeVisitor($scope));
+        $nodeTraverser->addVisitor(new ExprScopeFromStmtNodeVisitor($this, $filePath, $scope));
         $nodeTraverser->traverse($stmts);
 
         return $stmts;

rules-tests/CodeQuality/Rector/ClassMethod/OptionalParametersAfterRequiredRector/Fixture/skip_variable_variable5.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\OptionalParametersAfterRequiredRector\Fixture;
+
+abstract class SkipVariableVariable5
+{
+    public function run()
+    {
+        $$get_data = $get_data->Where(function ($query) use ($field, $key) {
+           $query->where($key, '!=', $field['search_value'][0]['val'])->orWhere($key, 'exists', false);
+        });
+    }
+}

src/PHPStan/NodeVisitor/ExprScopeFromStmtNodeVisitor.php

@@ -6,23 +6,26 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\ClassLike;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PhpParser\Node\Stmt\Namespace_;
 use PhpParser\NodeVisitorAbstract;
 use PHPStan\Analyser\MutatingScope;
-use PHPStan\Analyser\Scope;
 use PHPStan\Node\VirtualNode;
 use Rector\Core\PhpParser\Node\CustomNode\FileWithoutNamespace;
 use Rector\NodeTypeResolver\Node\AttributeKey;
+use Rector\NodeTypeResolver\PHPStan\Scope\PHPStanNodeScopeResolver;
 
 final class ExprScopeFromStmtNodeVisitor extends NodeVisitorAbstract
 {
     private ?Stmt $currentStmt = null;
 
     public function __construct(
+        private readonly PHPStanNodeScopeResolver $phpStanNodeScopeResolver,
+        private readonly string $filePath,
         private readonly MutatingScope $mutatingScope
     ) {
     }
@@ -52,7 +55,7 @@ public function enterNode(Node $node): ?Node
         }
 
         $scope = $node->getAttribute(AttributeKey::SCOPE);
-        if ($scope instanceof Scope) {
+        if ($scope instanceof MutatingScope) {
             return null;
         }
 
@@ -61,10 +64,14 @@ public function enterNode(Node $node): ?Node
             ? $this->currentStmt->getAttribute(AttributeKey::SCOPE)
             : $this->mutatingScope;
 
-        $scope = $scope instanceof Scope ? $scope : $this->mutatingScope;
+        $scope = $scope instanceof MutatingScope ? $scope : $this->mutatingScope;
 
         $node->setAttribute(AttributeKey::SCOPE, $scope);
 
+        if ($node instanceof Closure) {
+            $this->phpStanNodeScopeResolver->processNodes($node->stmts, $this->filePath, $scope);
+        }
+
         return null;
     }
 }