[Strict] Skip docblock on BooleanInBooleanNotRuleFixerRector (#4640)

* [Strict] Skip docblock on BooleanInBooleanNotRuleFixerRector * Fixed 🎉 * Fixed 🎉
rectorphp · Aug 3, 2023 · 8ffacac · 8ffacac
1 parent 8f6b366
commit 8ffacac
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 17 deletions.
diff --git a/...Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/skip_docblock.php.inc b/...Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/skip_docblock.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRector\Fixture;
+
+final class SkipDocblock
+{
+    /**
+     * @param null|string $value
+     */
+    public function run($value)
+    {
+        if (!$value) {
+            return 'empty';
+        }
+
+        return 'full';
+    }
+}
diff --git a/...rict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/union_with_null.php.inc b/...rict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector/Fixture/union_with_null.php.inc
@@ -6,10 +6,7 @@ namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRect
 
 final class UnionWithNull
 {
-    /**
-     * @var string|null
-     */
-    private $value;
+    private string|null $value = null;
 
     public function run()
     {
@@ -31,10 +28,7 @@ namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRect
 
 final class UnionWithNull
 {
-    /**
-     * @var string|null
-     */
-    private $value;
+    private string|null $value = null;
 
     public function run()
     {

diff --git a/...leanNot/BooleanInBooleanNotRuleFixerRector/FixtureTreatAsNonEmpty/union_with_null.php.inc b/...leanNot/BooleanInBooleanNotRuleFixerRector/FixtureTreatAsNonEmpty/union_with_null.php.inc
@@ -6,10 +6,7 @@ namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRect
 
 final class UnionWithNull
 {
-    /**
-     * @var string|null
-     */
-    private $value;
+    private string|null $value = null;
 
     public function run()
     {
@@ -31,10 +28,7 @@ namespace Rector\Tests\Strict\Rector\BooleanNot\BooleanInBooleanNotRuleFixerRect
 
 final class UnionWithNull
 {
-    /**
-     * @var string|null
-     */
-    private $value;
+    private string|null $value = null;
 
     public function run()
     {

diff --git a/rules/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector.php b/rules/Strict/Rector/BooleanNot/BooleanInBooleanNotRuleFixerRector.php
@@ -82,7 +82,7 @@ public function getNodeTypes(): array
      */
     public function refactorWithScope(Node $node, Scope $scope): ?Expr
     {
-        $exprType = $scope->getType($node->expr);
+        $exprType = $scope->getNativeType($node->expr);
         if ($exprType->isBoolean()->yes()) {
             return null;
         }