[Php81] Skip on Array Destructuring on ReadOnlyPropertyRector (#3030)

Co-authored-by: Elias Häußler <elias@haeussler.dev>

rules-tests/Php81/Rector/Property/ReadOnlyPropertyRector/Fixture/skip_property_on_array_destructuring.php.inc

@@ -0,0 +1,24 @@
+<?php
+
+namespace Rector\Tests\Php81\Rector\Property\ReadOnlyPropertyRector\Fixture;
+
+final class SkipPropetyOnArrayDestructuring
+{
+    public function __construct(
+        private ?string $accessToken = null,
+        private ?string $owner = null,
+        private ?string $name = null,
+    ) {
+    }
+
+    public function withVcs(string $value)
+    {
+        $clone = clone $this;
+        $clone->accessToken = $value;
+        [$clone->owner, $clone->name] = explode('/', $value, 2);
+
+        return $clone;
+    }
+}
+
+?>

src/NodeManipulator/AssignManipulator.php

@@ -6,7 +6,9 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr;
+use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\ArrayDimFetch;
+use PhpParser\Node\Expr\ArrayItem;
 use PhpParser\Node\Expr\Assign;
 use PhpParser\Node\Expr\AssignOp;
 use PhpParser\Node\Expr\FuncCall;
@@ -79,6 +81,10 @@ public function isLeftPartOfAssign(Node $node): bool
             return true;
         }
 
+        if ($this->isOnArrayDestructuring($parentNode)) {
+            return true;
+        }
+
         // traverse up to array dim fetches
         if ($parentNode instanceof ArrayDimFetch) {
             $previousParent = $parentNode;
@@ -128,4 +134,19 @@ public function resolveAssignsToLocalPropertyFetches(FunctionLike $functionLike)
             return $this->isLeftPartOfAssign($node);
         });
     }
+
+    private function isOnArrayDestructuring(?Node $parentNode): bool
+    {
+        if (! $parentNode instanceof ArrayItem) {
+            return false;
+        }
+
+        $parentArrayItem = $parentNode->getAttribute(AttributeKey::PARENT_NODE);
+        if (! $parentArrayItem instanceof Array_) {
+            return false;
+        }
+
+        $node = $parentArrayItem->getAttribute(AttributeKey::PARENT_NODE);
+        return $node instanceof Assign && $node->var === $parentArrayItem;
+    }
 }