[Php54][Php80] Handle no scope on LongArrayToShortArrayRector+Annotat…

…ionToAttributeRector (#2749)

* [Php54][Php80] Handle no scope on LongArrayToShortArrayRector+AnnotationToAttributeRector

* Fixed 🎉

* clean up

* phpstan

* phpstan

* final touch: eol

* cs fix

src/NodeAnalyzer/ScopeAnalyzer.php

@@ -37,6 +37,10 @@ public function isScopeResolvableFromFile(Node $node, ?MutatingScope $mutatingSc
         }
 
         $parentNode = $node->getAttribute(AttributeKey::PARENT_NODE);
-        return ! $parentNode instanceof Node;
+        if (! $parentNode instanceof Node) {
+            return true;
+        }
+
+        return ! $this->hasScope($parentNode);
     }
 }

tests/Issues/ScopeNotAvailable/ArrayAnnotationToAttributeTest.php

@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\ScopeNotAvailable;
+
+use Iterator;
+use Rector\Testing\PHPUnit\AbstractRectorTestCase;
+use Symplify\SmartFileSystem\SmartFileInfo;
+
+final class ArrayAnnotationToAttributeTest extends AbstractRectorTestCase
+{
+    /**
+     * @dataProvider provideData()
+     */
+    public function test(SmartFileInfo $fileInfo): void
+    {
+        $this->doTestFileInfo($fileInfo);
+    }
+
+    /**
+     * @return Iterator<SmartFileInfo>
+     */
+    public function provideData(): Iterator
+    {
+        return $this->yieldFilesFromDirectory(__DIR__ . '/FixtureArrayAnnotationToAttribute');
+    }
+
+    public function provideConfigFilePath(): string
+    {
+        return __DIR__ . '/config/array_annotation_to_attribute.php';
+    }
+}

tests/Issues/ScopeNotAvailable/FixtureArrayAnnotationToAttribute/array_in_attribute.php.inc

@@ -0,0 +1,38 @@
+<?php
+
+namespace Rector\Core\Tests\Issues\FixtureArrayAnnotationToAttribute\Fixture;
+
+use Doctrine\ORM\Mapping as ORM;
+
+class ArrayInAttribtue
+{
+    public function __construct(
+        /**
+         * @ORM\ManyToOne(targetEntity=OfferPrice::class, inversedBy="myEntities", cascade={"persist"})
+         */
+        private OfferPrice $offerPrice
+    )
+    {
+    }
+
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Core\Tests\Issues\FixtureArrayAnnotationToAttribute\Fixture;
+
+use Doctrine\ORM\Mapping as ORM;
+
+class ArrayInAttribtue
+{
+    public function __construct(
+        #[ORM\ManyToOne(targetEntity: OfferPrice::class, inversedBy: 'myEntities', cascade: ['persist'])] private OfferPrice $offerPrice
+    )
+    {
+    }
+
+}
+
+?>

tests/Issues/ScopeNotAvailable/config/array_annotation_to_attribute.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php54\Rector\Array_\LongArrayToShortArrayRector;
+use Rector\Php80\Rector\Class_\AnnotationToAttributeRector;
+use Rector\Php80\ValueObject\AnnotationToAttribute;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(LongArrayToShortArrayRector::class);
+
+    $rectorConfig->ruleWithConfiguration(AnnotationToAttributeRector::class, [
+        new AnnotationToAttribute('Doctrine\ORM\Mapping\ManyToOne'),
+    ]);
+};