[TypeDeclaration] Skip void return on AddArrowFunctionReturnTypeRector (

#3167)
rectorphp · Dec 7, 2022 · 99ac002 · 99ac002
1 parent b8aff08
commit 99ac002
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/...on/Rector/ArrowFunction/AddArrowFunctionReturnTypeRector/Fixture/skip_void_return.php.inc b/...on/Rector/ArrowFunction/AddArrowFunctionReturnTypeRector/Fixture/skip_void_return.php.inc
@@ -0,0 +1,16 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Closure\AddClosureReturnTypeRector\Fixture;
+
+final class SkipVoidReturn
+{
+    public function doNohing(string $a): void
+    {
+        echo $a;
+    }
+
+    public function run()
+    {
+        fn (string $a) => $this->doNohing($a);
+    }
+}
diff --git a/rules/TypeDeclaration/Rector/ArrowFunction/AddArrowFunctionReturnTypeRector.php b/rules/TypeDeclaration/Rector/ArrowFunction/AddArrowFunctionReturnTypeRector.php
@@ -6,6 +6,7 @@
 
 use PhpParser\Node;
 use PhpParser\Node\Expr\ArrowFunction;
+use PHPStan\Type\VoidType;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\ValueObject\PhpVersionFeature;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
@@ -51,6 +52,11 @@ public function refactor(Node $node): ?Node
         }
 
         $type = $this->getType($node->expr);
+
+        if ($type instanceof VoidType) {
+            return null;
+        }
+
         $returnTypeNode = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($type, TypeKind::RETURN);
 
         if ($returnTypeNode === null) {