[DX] Show warning on AbstractRector::__get() when pull deprecated pro…

…perty from AbstractRector (#5069)
rectorphp · Sep 23, 2023 · 9b319ef · 9b319ef
1 parent 9abbcb1
commit 9b319ef
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/Rector/AbstractRector.php b/src/Rector/AbstractRector.php
@@ -89,11 +89,23 @@ abstract class AbstractRector extends NodeVisitorAbstract implements RectorInter
      */
     private array $deprecatedDependencies = [];
 
+    /**
+     * @var array<class-string, array<string, bool>>
+     */
+    private array $cachedDeprecatedDependenciesWarning = [];
+
     /**
      * Handle deprecated dependencies compatbility
      */
     public function __get(string $name): mixed
     {
+        if (! isset($this->cachedDeprecatedDependenciesWarning[static::class][$name])) {
+            echo sprintf('Get %s property from AbstractRector on %s is deprecated, inject via __construct() instead', $name, static::class);
+            echo PHP_EOL;
+
+            $this->cachedDeprecatedDependenciesWarning[static::class][$name] = true;
+        }
+
         return $this->deprecatedDependencies[$name] ?? null;
     }