[DeadCode][Php56] Handle infinite loop on RemoveUnusedVariableAssignR…

…ector+AddDefaultValueForUndefinedVariableRector take 2 (#3941)

* [DeadCode][Php56] Handle infinite loop on RemoveUnusedVariableAssignRector+AddDefaultValueForUndefinedVariableRector take 2

* Fixed 🎉

* Fix phpstan

src/Application/ChangedNodeScopeRefresher.php

@@ -98,8 +98,17 @@ public function refresh(Node $node, ?MutatingScope $mutatingScope, ?string $file
 
     public function reIndexNodeAttributes(Node $node): void
     {
-        if (($node instanceof ClassLike || $node instanceof StmtsAwareInterface || $node instanceof Declare_) && $node->stmts !== null) {
-            $node->stmts = array_values($node->stmts);
+        if ($this->hasArrayStmtsNode($node)) {
+            /**
+             * @var StmtsAwareInterface|ClassLike|Declare_ $node
+             * @var Stmt[] $stmts
+             */
+            $stmts = $node->stmts;
+            $node->stmts = array_values($stmts);
+
+            foreach ($node->stmts as $key => $stmt) {
+                $stmt->setAttribute(AttributeKey::STMT_KEY, $key);
+            }
         }
 
         if ($node instanceof FunctionLike) {
@@ -129,6 +138,11 @@ public function reIndexNodeAttributes(Node $node): void
         }
     }
 
+    private function hasArrayStmtsNode(Node $node): bool
+    {
+        return ($node instanceof ClassLike || $node instanceof StmtsAwareInterface || $node instanceof Declare_) && $node->stmts !== null;
+    }
+
     /**
      * @return Stmt[]
      */

tests/Issues/RemoveUnusedVariableDefault/Fixture/re_used_assign.php.inc

@@ -0,0 +1,48 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\RemoveUnusedVariableDefault\Fixture;
+
+final class ReUsedAssign
+{
+    public function testCastAsJSONErrorDepth()
+    {
+        // Create array with depth 513 to get depth error
+        $array   = [];
+        $value   = 'test value';
+        $keys    = rtrim(str_repeat('test.', 513), '.');
+        $keys    = explode('.', $keys);
+        $current = $array;
+
+        foreach ($keys as $key) {
+            $current = $current[$key];
+        }
+    }
+}
+
+?>
+-----
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Core\Tests\Issues\RemoveUnusedVariableDefault\Fixture;
+
+final class ReUsedAssign
+{
+    public function testCastAsJSONErrorDepth()
+    {
+        // Create array with depth 513 to get depth error
+        $array   = [];
+        $keys    = rtrim(str_repeat('test.', 513), '.');
+        $keys    = explode('.', $keys);
+        $current = $array;
+
+        foreach ($keys as $key) {
+            $current = $current[$key];
+        }
+    }
+}
+
+?>