Cleanup scope check on UnreachableStatementNodeVisitor (#5648)

rectorphp · Feb 21, 2024 · a4445df · a4445df
1 parent 3b44873
commit a4445df
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/PHPStan/NodeVisitor/UnreachableStatementNodeVisitor.php b/src/PHPStan/NodeVisitor/UnreachableStatementNodeVisitor.php
@@ -38,7 +38,9 @@ public function enterNode(Node $node): ?Node
         $mutatingScope = $this->resolveScope($node->getAttribute(AttributeKey::SCOPE));
 
         foreach ($node->stmts as $stmt) {
-            if (! $stmt->getAttribute(AttributeKey::SCOPE) instanceof MutatingScope) {
+            $hasMutatingScope = $stmt->getAttribute(AttributeKey::SCOPE) instanceof MutatingScope;
+            if (! $hasMutatingScope) {
+                $stmt->setAttribute(AttributeKey::SCOPE, $mutatingScope);
                 $this->phpStanNodeScopeResolver->processNodes([$stmt], $this->filePath, $mutatingScope);
             }
 
@@ -49,7 +51,6 @@ public function enterNode(Node $node): ?Node
 
             if ($isPassedUnreachableStmt) {
                 $stmt->setAttribute(AttributeKey::IS_UNREACHABLE, true);
-                $stmt->setAttribute(AttributeKey::SCOPE, $mutatingScope);
             }
         }