[Transform] Handle crash string in EnumCase on StringToClassConstantR…

…ector (#2680)
rectorphp · Jul 18, 2022 · a66e653 · a66e653
1 parent c9ecc86
commit a66e653
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php b/packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php
@@ -16,6 +16,7 @@
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\Enum_;
+use PhpParser\Node\Stmt\EnumCase;
 use PhpParser\Node\Stmt\Expression;
 use PhpParser\Node\Stmt\Finally_;
 use PhpParser\Node\Stmt\Foreach_;
@@ -110,7 +111,12 @@ public function processNodes(
             $isScopeRefreshing,
             $smartFileInfo
         ): void {
-            if (($node instanceof Expression || $node instanceof Return_) && $node->expr instanceof Expr) {
+            if ((
+                $node instanceof Expression ||
+                $node instanceof Return_ ||
+                $node instanceof Assign ||
+                $node instanceof EnumCase
+            ) && $node->expr instanceof Expr) {
                 $node->expr->setAttribute(AttributeKey::SCOPE, $mutatingScope);
             }
 
@@ -149,7 +155,6 @@ public function processNodes(
 
             if ($node instanceof Assign) {
                 // decorate value as well
-                $node->expr->setAttribute(AttributeKey::SCOPE, $mutatingScope);
                 $node->var->setAttribute(AttributeKey::SCOPE, $mutatingScope);
             }
 

diff --git a/...rm/Rector/String_/StringToClassConstantRector/Fixture/skip_not_found_in_enum_case.php.inc b/...rm/Rector/String_/StringToClassConstantRector/Fixture/skip_not_found_in_enum_case.php.inc
@@ -0,0 +1,8 @@
+<?php
+
+namespace Rector\Tests\Transform\Rector\String_\StringToClassConstantRector\Fixture;
+
+enum SkipNotFoundInEnumCase: string
+{
+    case A = 'a';
+}