Skip to content

Commit

Permalink
[PHPStan] Clean up PHPStan ignore errrors (#5492)
Browse files Browse the repository at this point in the history
* [PHPStan] Clean up PHPStan ignore errrors

* [PHPStan] Clean up PHPStan ignore errrors

* fix
  • Loading branch information
samsonasik committed Jan 23, 2024
1 parent f7caedf commit ab78d14
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
8 changes: 0 additions & 8 deletions phpstan.neon
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,6 @@ parameters:
- rules/Php70/EregToPcreTransformer.php
- rules/DeadCode/NodeManipulator/LivingCodeManipulator.php
- rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php
- src/FileSystem/FilesFinder.php
- src/PhpParser/NodeTransformer.php

# impossible to validate json string is a class-string
Expand Down Expand Up @@ -261,10 +260,6 @@ parameters:
# regex
- rules/Php70/EregToPcreTransformer.php

-
message: '#Instead of "DateTime" class/interface use "Nette\\Utils\\DateTime"#'
path: src/Application/VersionResolver.php

- '#Method "replaceTagByAnother\(\)" returns bool type, so the name should start with is/has/was#'
- '#Method "refactorPhpDoc\(\)" returns bool type, so the name should start with is/has/was#'

Expand Down Expand Up @@ -477,6 +472,3 @@ parameters:

# closure detailed
- '#Method Rector\\Config\\RectorConfig\:\:singleton\(\) has parameter \$concrete with no signature specified for Closure#'

# will be used in rector-downgrade-php
- '#Public method "Rector\\PhpParser\\Parser\\InlineCodeParser\:\:parseFile\(\)" is never used#'
2 changes: 2 additions & 0 deletions src/PhpParser/Parser/InlineCodeParser.php
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ public function parse(string $content): array
}

/**
* @api downgrade
*
* @return Stmt[]
*/
public function parseFile(string $fileName): array
Expand Down

0 comments on commit ab78d14

Please sign in to comment.