[Core] Improve performance: only reindex Node Attributes when Origina…

…l Node is not null (#3043)
rectorphp · Nov 11, 2022 · ac8fc4c · ac8fc4c
1 parent b31bb42
commit ac8fc4c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/Rector/AbstractRector.php b/src/Rector/AbstractRector.php
@@ -206,7 +206,10 @@ final public function enterNode(Node $node)
 
         $this->printDebugCurrentFileAndRule();
 
-        $this->changedNodeScopeRefresher->reIndexNodeAttributes($node);
+        $originalNode = $node->getAttribute(AttributeKey::ORIGINAL_NODE);
+        if ($originalNode instanceof Node) {
+            $this->changedNodeScopeRefresher->reIndexNodeAttributes($node);
+        }
 
         $refactoredNode = $this->refactor($node);
 
@@ -220,8 +223,7 @@ final public function enterNode(Node $node)
             throw new ShouldNotHappenException($errorMessage);
         }
 
-        /** @var Node $originalNode */
-        $originalNode = $node->getAttribute(AttributeKey::ORIGINAL_NODE) ?? $node;
+        $originalNode ??= $node;
 
         /** @var Node[]|Node $refactoredNode */
         $this->createdByRuleDecorator->decorate($refactoredNode, $originalNode, static::class);