[Core] Add Smarty Support for PhpFilesFinder check non-PHP files (#736)

rectorphp · Aug 22, 2021 · af1cbb9 · af1cbb9
1 parent b422a9d
commit af1cbb9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 6 deletions.
diff --git a/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php b/rules/CodeQuality/Rector/Foreach_/ForeachItemsAssignToEmptyArrayToAssignRector.php
@@ -116,7 +116,6 @@ private function shouldSkip(Foreach_ $foreach): bool
         }
 
         $scope = $foreach->expr->getAttribute(AttributeKey::SCOPE);
-
         if (! $scope instanceof Scope) {
             return true;
         }

diff --git a/src/FileSystem/PhpFilesFinder.php b/src/FileSystem/PhpFilesFinder.php
@@ -9,6 +9,16 @@
 
 final class PhpFilesFinder
 {
+    /**
+     * @var string[]
+     */
+    private const NON_PHP_FILE_EXTENSIONS = [
+        // Laravel
+        '.blade.php',
+        // Smarty
+        '.tpl',
+    ];
+
     public function __construct(
         private FilesFinder $filesFinder,
         private UnchangedFilesFilter $unchangedFilesFilter
@@ -23,11 +33,16 @@ public function findInPaths(array $paths): array
     {
         $phpFileInfos = $this->filesFinder->findInDirectoriesAndFiles($paths);
 
-        // filter out non-PHP php files, e.g. blade templates in Laravel
-        $phpFileInfos = array_filter(
-            $phpFileInfos,
-            fn (SmartFileInfo $smartFileInfo): bool => ! \str_ends_with($smartFileInfo->getPathname(), '.blade.php')
-        );
+        // filter out non-PHP files
+        foreach ($phpFileInfos as $key => $phpFileInfo) {
+            $pathName = $phpFileInfo->getPathname();
+            foreach (self::NON_PHP_FILE_EXTENSIONS as $nonPHPFileExtension) {
+                if (str_ends_with($pathName, $nonPHPFileExtension)) {
+                    unset($phpFileInfos[$key]);
+                    continue 2;
+                }
+            }
+        }
 
         return $this->unchangedFilesFilter->filterAndJoinWithDependentFileInfos($phpFileInfos);
     }