[CodeQuality] Skip __construct() method on ExplicitReturnNullRector (#…

…5758)
rectorphp · Mar 22, 2024 · b042152 · b042152
1 parent 61c7e92
commit b042152
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/...ts/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector/Fixture/skip_construct.php.inc b/...ts/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector/Fixture/skip_construct.php.inc
@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\ExplicitReturnNullRector\Fixture;
+
+class SkipConstruct
+{
+    public function __construct(int $number)
+    {
+        if ($number > 50) {
+            return 'yes';
+        }
+
+        echo 'test';
+    }
+}
diff --git a/rules/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector.php b/rules/CodeQuality/Rector/ClassMethod/ExplicitReturnNullRector.php
@@ -21,6 +21,7 @@
 use Rector\PhpParser\Node\BetterNodeFinder;
 use Rector\Rector\AbstractRector;
 use Rector\TypeDeclaration\TypeInferer\SilentVoidResolver;
+use Rector\ValueObject\MethodName;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
 
@@ -100,6 +101,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($this->isName($node, MethodName::CONSTRUCT)) {
+            return null;
+        }
+
         if ($this->containsYieldOrThrow($node)) {
             return null;
         }