Defer type-resolving in RemoveJustPropertyFetchRector (#3761)

rectorphp · May 8, 2023 · b116bc0 · b116bc0
1 parent 01c1377
commit b116bc0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustPropertyFetchRector.php b/rules/DeadCode/Rector/StmtsAwareInterface/RemoveJustPropertyFetchRector.php
@@ -246,10 +246,6 @@ private function matchVariableToPropertyAssign(Stmt $stmt): ?PropertyFetchToVari
             return null;
         }
 
-        if ($this->isPropertyFetchCallerNode($assign->expr)) {
-            return null;
-        }
-
         // keep property fetch nesting
         if ($assign->expr->var instanceof PropertyFetch) {
             return null;
@@ -259,6 +255,10 @@ private function matchVariableToPropertyAssign(Stmt $stmt): ?PropertyFetchToVari
             return null;
         }
 
+        if ($this->isPropertyFetchCallerNode($assign->expr)) {
+            return null;
+        }
+
         return new PropertyFetchToVariableAssign($assign->var, $assign->expr);
     }