Skip argument if value equals default value (#4368)

rules-tests/Arguments/Rector/ClassMethod/ArgumentAdderRector/Fixture/skip_add_with_default_value.php.inc

@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\Arguments\Rector\ClassMethod\ArgumentAdderRector\Fixture;
+
+use Rector\Tests\Arguments\Rector\ClassMethod\ArgumentAdderRector\Source\SomeClass;
+
+class SkipAddWithDefaultValue
+{
+    public function skip(): void
+    {
+        $someClass = new SomeClass();
+        $someClass->someMethod();
+    }
+}

rules-tests/Arguments/Rector/ClassMethod/ArgumentAdderRector/Source/SomeClass.php

@@ -4,5 +4,8 @@
 
 class SomeClass
 {
+    public function someMethod($default = 1): void
+    {
+    }
 
 }

rules-tests/Arguments/Rector/ClassMethod/ArgumentAdderRector/config/configured_rule.php

@@ -52,5 +52,6 @@
             ),
             new ArgumentAdder(SomeClass::class, 'withoutTypeOrDefaultValue', 0, 'arguments', [], $arrayType),
             new ArgumentAdder(SomeMultiArg::class, 'run', 2, 'c', 4),
+            new ArgumentAdder(SomeClass::class, 'someMethod', 0, 'default', 1),
         ]);
 };

rules/Arguments/Rector/ClassMethod/ArgumentAdderRector.php

@@ -251,6 +251,17 @@ private function shouldSkipParameter(
             return true;
         }
 
+        // Check if default value is the same
+        $classMethod = $this->astResolver->resolveClassMethodFromCall($node);
+        if (($classMethod instanceof ClassMethod) &&
+            isset($classMethod->params[$position]) &&
+            ! $this->changedArgumentsDetector->isDefaultValueChanged(
+                $classMethod->params[$position],
+                $argumentAdder->getArgumentDefaultValue()
+            )) {
+            return true;
+        }
+
         // is correct scope?
         return ! $this->argumentAddingScope->isInCorrectScope($node, $argumentAdder);
     }