[DeadCode] Handle crash on has first class callable on RemoveUnusedCo…

…nstructorParamRector (#3015)

* [DeadCode] Handle has first class callable on RemoveUnusedConstructorParamRector

* Fixed 🎉

* final touch: more fixture

rules-tests/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector/Fixture/has_first_class_callable.php.inc

@@ -0,0 +1,43 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector\Fixture;
+
+final class HasFirstClassCallable
+{
+    private $hey;
+
+    public function __construct($hey, $man)
+    {
+        $this->hey = $hey;
+
+        $this->execute(...);
+    }
+
+    private function execute()
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector\Fixture;
+
+final class HasFirstClassCallable
+{
+    private $hey;
+
+    public function __construct($hey)
+    {
+        $this->hey = $hey;
+
+        $this->execute(...);
+    }
+
+    private function execute()
+    {
+    }
+}
+
+?>

rules-tests/DeadCode/Rector/ClassMethod/RemoveUnusedConstructorParamRector/Fixture/skip_used_by_exec_first_class_callable.php.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\ClassMethod\RemoveUnusedConstructorParamRector\Fixture;
+
+final class SkipUsedByExecFirstClassCallable
+{
+    private $hey;
+
+    public function __construct($hey, $man)
+    {
+        $this->hey = $hey;
+
+        $this->execute(...)($man);
+    }
+
+    private function execute($man)
+    {
+        echo $man;
+    }
+}

src/NodeAnalyzer/ParamAnalyzer.php

@@ -147,6 +147,10 @@ private function isVariableInClosureUses(Closure $closure, Variable $variable):
     private function isUsedAsArg(Node $node, Param $param): bool
     {
         if ($node instanceof New_ || $node instanceof CallLike) {
+            if ($node->isFirstClassCallable()) {
+                return false;
+            }
+
             foreach ($node->getArgs() as $arg) {
                 if ($this->nodeComparator->areNodesEqual($param->var, $arg->value)) {
                     return true;