[CodeQuality] Skip Closure call on CompleteDynamicPropertiesRector (#668

)

Co-authored-by: Zoran Antolovic <zoran.antolovic.os@gmail.com>

rules-tests/CodeQuality/Rector/Class_/CompleteDynamicPropertiesRector/Fixture/skip_closure_call.php.inc

@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector\Fixture;
+
+use stdClass;
+
+class SkipClosureCall
+{
+    public function getPrivateProperty()
+    {
+        $randomGenerator = new stdClass();
+
+        (function () {
+            return $this->uuidV4Generator;
+        })->call($randomGenerator);
+    }
+}

rules/CodeQuality/NodeAnalyzer/LocalPropertyAnalyzer.php

@@ -11,6 +11,7 @@
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\PropertyFetch;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\FunctionLike;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\NodeTraverser;
@@ -80,6 +81,11 @@ public function resolveFetchedPropertiesToTypesFromClass(Class_ $class): array
                 return null;
             }
 
+            $parentFunctionLike = $this->betterNodeFinder->findParentType($node, FunctionLike::class);
+            if (! $parentFunctionLike instanceof ClassMethod) {
+                return null;
+            }
+
             $propertyFetchType = $this->resolvePropertyFetchType($node);
             $fetchedLocalPropertyNameToTypes[$propertyName][] = $propertyFetchType;