[Strict] Skip @return docblock on BooleanInIfConditionRuleFixerRector (…

…#4609) * [Strict] Skip @return docblock on BooleanInIfConditionRuleFixerRector * fix
rectorphp · Jul 26, 2023 · b5f973f · b5f973f
1 parent 65e6cae
commit b5f973f
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/.../Rector/If_/BooleanInIfConditionRuleFixerRector/Fixture/skip_from_return_docblock.php.inc b/.../Rector/If_/BooleanInIfConditionRuleFixerRector/Fixture/skip_from_return_docblock.php.inc
@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Tests\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector\Fixture;
+
+final class SkipFromReturnDocblock
+{
+    /**
+     * @return array
+     */
+    private function getItems()
+    {
+    }
+
+    public function run()
+    {
+        if ($this->getItems()) {
+            return true;
+        }
+
+        return false;
+    }
+}
diff --git a/rules/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector.php b/rules/Strict/Rector/If_/BooleanInIfConditionRuleFixerRector.php
@@ -86,7 +86,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?If_
         $hasChanged = false;
 
         // 1. if
-        $ifCondExprType = $scope->getType($node->cond);
+        $ifCondExprType = $scope->getNativeType($node->cond);
         $notIdentical = $this->exactCompareFactory->createNotIdenticalFalsyCompare(
             $ifCondExprType,
             $node->cond,
@@ -100,7 +100,7 @@ public function refactorWithScope(Node $node, Scope $scope): ?If_
 
         // 2. elseifs
         foreach ($node->elseifs as $elseif) {
-            $elseifCondExprType = $scope->getType($elseif->cond);
+            $elseifCondExprType = $scope->getNativeType($elseif->cond);
             $notIdentical = $this->exactCompareFactory->createNotIdenticalFalsyCompare(
                 $elseifCondExprType,
                 $elseif->cond,