[Php56] Reduce origNode check on UndefinedVariableResolver (#4033)

rectorphp · May 30, 2023 · b84fe95 · b84fe95
1 parent 73c1ac4
commit b84fe95
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php b/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php
@@ -57,22 +57,14 @@ public function resolve(ClassMethod | Function_ | Closure $node): array
         ): ?int {
             // entering new scope - break!
             if ($node instanceof FunctionLike && ! $node instanceof ArrowFunction) {
-                return NodeTraverser::STOP_TRAVERSAL;
+                return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
             }
 
             if ($node instanceof Foreach_) {
                 // handled above
                 return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
             }
 
-            /**
-             * The Node that doesn't have origNode attribute yet
-             * means the Node is a replacement below other changed node
-             */
-            if (! $node->hasAttribute(AttributeKey::ORIGINAL_NODE)) {
-                return NodeTraverser::DONT_TRAVERSE_CURRENT_AND_CHILDREN;
-            }
-
             if (! $node instanceof Variable) {
                 return null;
             }