[Php56] Skip variable variable on AddDefaultValueForUndefinedVariable…

…Rector (#4148) * [Php56] Skip variable variable on AddDefaultValueForUndefinedVariableRector * Fixed 🎉 * comment
rectorphp · Jun 10, 2023 · b92e378 · b92e378
1 parent 6758a5e
commit b92e378
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/...tionLike/AddDefaultValueForUndefinedVariableRector/Fixture/skip_variable_variable.php.inc b/...tionLike/AddDefaultValueForUndefinedVariableRector/Fixture/skip_variable_variable.php.inc
@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Php56\Rector\FunctionLike\AddDefaultValueForUndefinedVariableRector\Fixture;
+
+class SkipVariableVariable
+{
+    public function run($abcdef = 'foo')
+    {
+        $$abcdef = 'test';
+
+        return $foo;
+    }
+}
diff --git a/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php b/rules/Php56/NodeAnalyzer/UndefinedVariableResolver.php
@@ -75,6 +75,11 @@ public function resolve(ClassMethod | Function_ | Closure $node): array
                 return null;
             }
 
+            // after variable variable, the variable name got unpredictable, just stop
+            if ($node->name instanceof Variable) {
+                return NodeTraverser::STOP_TRAVERSAL;
+            }
+
             if ($node->getAttribute(AttributeKey::IS_BEING_ASSIGNED) === true) {
                 return null;
             }
@@ -215,11 +220,6 @@ private function shouldSkipVariable(Variable $variable, string $variableName, ar
             return true;
         }
 
-        $checkedVariables = array_filter(
-            $checkedVariables,
-            static fn (string $variableName): bool => $variableName !== ''
-        );
-
         return in_array($variableName, $checkedVariables, true);
     }