[Scoped] Fix downgrade AsciiSlugger (#1349)

rectorphp · Nov 30, 2021 · bc96dde · bc96dde
1 parent 07de4ed
commit bc96dde
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/build/config/config-downgrade.php b/build/config/config-downgrade.php
@@ -107,7 +107,6 @@ final class DowngradeRectorConfig
         // loaded with "require-dev" so it'd throw an error
 
         // use relative paths, so files are excluded on nested directory too
-        'vendor/symfony/string/Slugger/AsciiSlugger.php',
         'vendor/symfony/cache/*',
         // no event-dispatcher used
         'vendor/symfony/console/Event/*',

diff --git a/rules/DowngradePhp80/Rector/New_/DowngradeArbitraryExpressionsSupportRector.php b/rules/DowngradePhp80/Rector/New_/DowngradeArbitraryExpressionsSupportRector.php
@@ -130,11 +130,13 @@ private function isBetweenParentheses(Node $node): ?bool
             $token = $oldTokens[$previousTokenPos] ?? null;
             --$previousTokenPos;
 
-            if (isset($token[0]) && in_array($token[0], [\T_COMMENT, \T_WHITESPACE], true)) {
-                continue;
+            if (! isset($token[0])) {
+                return $token === '(';
             }
 
-            return $token === '(';
+            if (! in_array($token[0], [\T_COMMENT, \T_WHITESPACE], true)) {
+                return $token === '(';
+            }
         }
 
         return false;