[PHPStanStaticTypeMapper] Improve UnionTypeMapper performance (#3686)

early in_array instead of in loop
rectorphp · Apr 25, 2023 · bd478cc · bd478cc
1 parent 92d38cf
commit bd478cc
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php b/packages/PHPStanStaticTypeMapper/TypeMapper/UnionTypeMapper.php
@@ -252,9 +252,17 @@ private function resolveUnionTypes(PhpParserUnionType $phpParserUnionType): ?Php
                 $identifierNames[] = $type->toString();
             }
         }
+
+        if (! in_array('bool', $identifierNames, true)) {
+            return $phpParserUnionType;
+        }
+
+        if (! in_array('false', $identifierNames, true)) {
+            return $phpParserUnionType;
+        }
 
         foreach ($phpParserUnionType->types as $key => $type) {
-            if ($type instanceof Identifier && in_array('bool', $identifierNames, true) && $type->toString() === 'false') {
+            if ($type instanceof Identifier && $type->toString() === 'false') {
                 unset($phpParserUnionType->types[$key]);
                 $phpParserUnionType->types = array_values($phpParserUnionType->types);