CountArrayToEmptyArrayComparisonRector: don't trust phpdoc (#5203)

* CountArrayToEmptyArrayComparisonRector: don't trust phpdoc * Update on_call_method_return_array.php.inc * Update on_call_method_return_array.php.inc
rectorphp · Oct 26, 2023 · be0cc77 · be0cc77
1 parent 72cdbd0
commit be0cc77
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 3 deletions.
diff --git a/...gStyle/Rector/FuncCall/CountArrayToEmptyArrayComparisonRector/Fixture/skip_phpdoc.php.inc b/...gStyle/Rector/FuncCall/CountArrayToEmptyArrayComparisonRector/Fixture/skip_phpdoc.php.inc
@@ -0,0 +1,14 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\FuncCall\CountArrayToEmptyArrayComparisonRector\Fixture;
+
+/**
+ * @var Rechnung[]            $Rechnung
+ */
+
+if ($Rechnung && count($Rechnung) > 0) {
+
+}
+
+
+?>
diff --git a/rules/CodingStyle/Rector/FuncCall/CountArrayToEmptyArrayComparisonRector.php b/rules/CodingStyle/Rector/FuncCall/CountArrayToEmptyArrayComparisonRector.php
@@ -117,7 +117,7 @@ private function refactorBooleanNot(BooleanNot $booleanNot): ?Identical
 
     private function isArray(Expr $expr): bool
     {
-        return $this->getType($expr)
+        return $this->nodeTypeResolver->getNativeType($expr)
             ->isArray()
             ->yes();
     }

diff --git a/tests/Issues/Issue6561/Fixture/on_call_method_return_array.php.inc b/tests/Issues/Issue6561/Fixture/on_call_method_return_array.php.inc
@@ -15,7 +15,7 @@ final class OnCallMethodReturnArray
     /**
      * @return string[]
      */
-    private function get()
+    private function get(): array
     {
         return ['a', 'b'];
     }
@@ -40,7 +40,7 @@ final class OnCallMethodReturnArray
     /**
      * @return string[]
      */
-    private function get()
+    private function get(): array
     {
         return ['a', 'b'];
     }