[Privatization][TypeDeclaration] Skip inside class with @Final docblo…

…ck on PrivatizeFinalClassMethodRector and AddVoidReturnTypeWhereNoReturnRector (#3190)

Co-authored-by: GitHub Action <action@github.com>

rules-tests/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector/Fixture/skip_final_docblock.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\Privatization\Rector\ClassMethod\PrivatizeFinalClassMethodRector\Fixture;
+
+/**
+ * @final
+ */
+class SkipFinalDocblock
+{
+    protected function someMethod()
+    {
+    }
+}

rules-tests/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector/Fixture/skip_final_docblock.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector\Fixture;
+
+/**
+ * @final
+ */
+class SkipFinalDocblock
+{
+    protected function someMethod()
+    {
+    }
+}

rules/Privatization/Rector/ClassMethod/PrivatizeFinalClassMethodRector.php

@@ -5,10 +5,12 @@
 namespace Rector\Privatization\Rector\ClassMethod;
 
 use PhpParser\Node;
+use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Reflection\ClassReflection;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\Reflection\ReflectionResolver;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\Privatization\NodeManipulator\VisibilityManipulator;
 use Rector\Privatization\VisibilityGuard\ClassMethodVisibilityGuard;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
@@ -72,11 +74,12 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
-        if (! $classReflection->isClass()) {
+        $class = $node->getAttribute(AttributeKey::PARENT_NODE);
+        if (! $class instanceof Class_) {
             return null;
         }
 
-        if (! $classReflection->isFinal()) {
+        if (! $class->isFinal()) {
             return null;
         }
 

rules/TypeDeclaration/Rector/ClassMethod/AddVoidReturnTypeWhereNoReturnRector.php

@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\Closure;
 use PhpParser\Node\Identifier;
+use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
 use PhpParser\Node\Stmt\Function_;
 use PHPStan\Reflection\ClassReflection;
@@ -17,6 +18,7 @@
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\Reflection\ReflectionResolver;
 use Rector\Core\ValueObject\PhpVersionFeature;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\TypeDeclaration\TypeInferer\SilentVoidResolver;
 use Rector\VendorLocker\NodeVendorLocker\ClassMethodReturnVendorLockResolver;
 use Rector\VersionBonding\Contract\MinPhpVersionInterface;
@@ -176,6 +178,11 @@ private function isInsideFinalClass(ClassMethod $classMethod): bool
             return false;
         }
 
-        return $classReflection->isFinal();
+        $node = $classMethod->getAttribute(AttributeKey::PARENT_NODE);
+        if (! $node instanceof Class_) {
+            return false;
+        }
+
+        return $node->isFinal();
     }
 }