[e2e] Add e2e for tests removed node display applied rules with retur…

…n null (#2320)

* [e2e] Add e2e for tests removed node display applied rules with return null

* update

.github/workflows/e2e.yaml

@@ -31,6 +31,7 @@ jobs:
                     - 'e2e/plain-views'
                     - 'e2e/template-extends'
                     - 'e2e/use-rector-configurator'
+                    - 'e2e/applied-rule-removed-node'
 
         name: End to end test - ${{ matrix.directory }}
 

e2e/applied-rule-removed-node/.gitignore

@@ -0,0 +1 @@
+/vendor

e2e/applied-rule-removed-node/composer.json

@@ -0,0 +1,7 @@
+{
+    "require": {
+        "php": "^8.1"
+    },
+    "minimum-stability": "dev",
+    "prefer-stable": true
+}

e2e/applied-rule-removed-node/expected-output.diff

@@ -0,0 +1,40 @@
+2 files with changes
+====================
+
+1) src/DeadConstructor.php:1
+
+    ---------- begin diff ----------
+@@ @@
+
+ final class DeadConstructor
+ {
+-    public function __construct()
+-    {
+-    }
+ }
+    ----------- end diff -----------
+
+Applied rules:
+ * RemoveDeadConstructorRector
+
+
+2) src/AlwaysTrue.php:3
+
+    ---------- begin diff ----------
+@@ @@
+ {
+     public function run()
+     {
+-        if (1 === 1) {
+-        }
+-
+         return 'no';
+     }
+ }
+    ----------- end diff -----------
+
+Applied rules:
+ * RemoveAlwaysTrueIfConditionRector
+
+
+ [OK] 2 files would have changed (dry-run) by Rector

e2e/applied-rule-removed-node/rector.php

@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\DeadCode\Rector\ClassMethod\RemoveDeadConstructorRector;
+use Rector\DeadCode\Rector\If_\RemoveAlwaysTrueIfConditionRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->paths([
+        __DIR__ . '/src',
+    ]);
+
+    $rectorConfig->rule(RemoveDeadConstructorRector::class);
+    $rectorConfig->rule(RemoveAlwaysTrueIfConditionRector::class);
+};

e2e/applied-rule-removed-node/src/AlwaysTrue.php

@@ -0,0 +1,12 @@
+<?php
+
+final class AlwaysTrue
+{
+    public function run()
+    {
+        if (1 === 1) {
+        }
+
+        return 'no';
+    }
+}

e2e/applied-rule-removed-node/src/DeadConstructor.php

@@ -0,0 +1,8 @@
+<?php
+
+final class DeadConstructor
+{
+    public function __construct()
+    {
+    }
+}

rules/DeadCode/Rector/If_/RemoveAlwaysTrueIfConditionRector.php

@@ -84,8 +84,7 @@ public function refactor(Node $node): If_|null|array
 
         if ($node->stmts === []) {
             $this->removeNode($node);
-            // needed to apply removeNode(), @todo fix in AbstractRector itself
-            return $node;
+            return null;
         }
 
         return $node->stmts;