Resolve native return-type from native union-type in short ternary (#…

…4606)

* Resolve native type from method call in short ternary

* Update ReturnTypeFromStrictTernaryRector.php

* fix class-name conflict

* Update return_from_ternary_phpdoc.php.inc

* fix

* Update skip_union_void.inc

* Update skip_union_void.inc

* more gracefull error handling

* Update rules/TypeDeclaration/Rector/Class_/ReturnTypeFromStrictTernaryRector.php

---------

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

rules-tests/TypeDeclaration/Rector/Class_/ReturnTypeFromStrictTernaryRector/Fixture/return_from_ternary.php.inc

@@ -0,0 +1,39 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Class_\ReturnTypeFromStrictTernaryRector\Fixture;
+
+class Appointment
+{
+    private function find_one(): self|false {
+        return false;
+    }
+
+    public function getRent()
+    {
+        $rent = $this->find_one();
+
+        return $rent ?: null;
+    }
+
+}
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Class_\ReturnTypeFromStrictTernaryRector\Fixture;
+
+class Appointment
+{
+    private function find_one(): self|false {
+        return false;
+    }
+
+    public function getRent(): ?\Rector\Tests\TypeDeclaration\Rector\Class_\ReturnTypeFromStrictTernaryRector\Fixture\Appointment
+    {
+        $rent = $this->find_one();
+
+        return $rent ?: null;
+    }
+
+}
+?>

rules-tests/TypeDeclaration/Rector/Class_/ReturnTypeFromStrictTernaryRector/Fixture/skip_union_void.inc

@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\Class_\ReturnTypeFromStrictTernaryRector\Fixture;
+
+class SkipUnionVoid
+{
+    private function find_one(): self|false {
+        return false;
+    }
+
+    public function getRent()
+    {
+        if (random_int(0 ,1 )) {
+            $rent = $this->find_one();
+
+            return $rent ?: null;
+        }
+    }
+
+}

rules/TypeDeclaration/Rector/Class_/ReturnTypeFromStrictTernaryRector.php

@@ -16,6 +16,7 @@
 use PHPStan\Type\UnionType;
 use Rector\Core\Rector\AbstractScopeAwareRector;
 use Rector\Core\ValueObject\PhpVersionFeature;
+use Rector\NodeTypeResolver\Node\AttributeKey;
 use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
 use Rector\TypeDeclaration\TypeInferer\ReturnTypeInferer;
 use Rector\VendorLocker\NodeVendorLocker\ClassMethodReturnTypeOverrideGuard;
@@ -95,7 +96,12 @@ public function refactorWithScope(Node $node, Scope $scope): ?Node
 
         $ternary = $return->expr;
 
-        $nativeTernaryType = $scope->getNativeType($ternary);
+        $returnScope = $return->expr->getAttribute(AttributeKey::SCOPE);
+        if ($returnScope === null) {
+            return null;
+        }
+
+        $nativeTernaryType = $returnScope->getNativeType($ternary);
         if ($nativeTernaryType instanceof MixedType) {
             return null;
         }