[CodeQuality] Skip Child class of \DateTime on DateTimeToDateTimeInte…

…rfaceRector (#703)

* Add failing test fixture for DateTimeToDateTimeInterfaceRector

Relates to #6641

* Change order of namespace and imports

Previous one was generated by Rector's Demo.

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

* Do not force \DateTimeInterface for args based on \DateTime child classes

* Rename fixture file name

* Add more tests for skipping refactorization

Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>

rules-tests/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector/Fixture/skip_child_class.php.inc

@@ -0,0 +1,26 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\DateTimeToDateTimeInterfaceRector\Fixture;
+
+use DateTime as PhpDateTime;
+
+class DateTime extends PhpDateTime
+{
+    public function getDateTimeCustomFormat(): ?string
+    {
+        return $this->format('Y-m-d H:i:s');
+    }
+}
+
+class Foo
+{
+    public static function bar(?DateTime $datetime)
+    {
+        // ...
+    }
+
+    public static function baz(DateTime $datetime)
+    {
+        // ...
+    }
+}

rules-tests/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector/Fixture/skip_different_type.php.inc

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\DateTimeToDateTimeInterfaceRector\Fixture;
+
+use stdClass;
+
+class SkipDifferentType
+{
+    public static function run(stdClass $stdClass)
+    {
+    }
+}

rules-tests/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector/Fixture/skip_no_type.php.inc

@@ -0,0 +1,10 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\DateTimeToDateTimeInterfaceRector\Fixture;
+
+class SkipNoType
+{
+    public static function run($param)
+    {
+    }
+}

rules-tests/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector/Fixture/skip_union_type.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\DateTimeToDateTimeInterfaceRector\Fixture;
+
+use DateTime;
+use DateTimeImmutable;
+
+class SkipUnionType
+{
+    public function run(DateTime|DateTimeImmutable $dateTime)
+    {
+    }
+}

rules/CodeQuality/Rector/ClassMethod/DateTimeToDateTimeInterfaceRector.php

@@ -88,8 +88,16 @@ public function getNodeTypes(): array
     public function refactor(Node $node): ?Node
     {
         $isModifiedNode = false;
+        $dateTimeObject = new ObjectType('DateTime');
+
         foreach ($node->getParams() as $param) {
-            if (! $this->isObjectType($param, new ObjectType('DateTime'))) {
+            if (! $this->isObjectType($param, $dateTimeObject)) {
+                continue;
+            }
+
+            // Do not refactor if node's type is a child class of \DateTime (can have wider API)
+            $paramType = $this->nodeTypeResolver->resolve($param);
+            if (!$paramType->isSuperTypeOf($dateTimeObject)->yes()) {
                 continue;
             }