Improve ParentClassMethodTypeOverrideGuard performance (#3660)

* Improve ParentClassMethodTypeOverrideGuard performance * use instanceof
rectorphp · Apr 23, 2023 · c7379ec · c7379ec
1 parent a729d72
commit c7379ec
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/packages/VendorLocker/ParentClassMethodTypeOverrideGuard.php b/packages/VendorLocker/ParentClassMethodTypeOverrideGuard.php
@@ -37,14 +37,20 @@ public function getParentClassMethod(ClassMethod $classMethod): ?MethodReflectio
 
         /** @var string $methodName */
         $methodName = $this->nodeNameResolver->getName($classMethod);
-        $parentClassReflections = array_merge($classReflection->getParents(), $classReflection->getInterfaces());
+        $parentClassReflection = $classReflection->getParentClass();
+        while  ($parentClassReflection instanceof ClassReflection) {
+            if ($parentClassReflection->hasNativeMethod($methodName)) {
+                return $parentClassReflection->getNativeMethod($methodName);
+            }
+            $parentClassReflection = $parentClassReflection->getParentClass();
+        }
 
-        foreach ($parentClassReflections as $parentClassReflection) {
-            if (! $parentClassReflection->hasNativeMethod($methodName)) {
+        foreach ($classReflection->getInterfaces() as $interfaceReflection) {
+            if (! $interfaceReflection->hasNativeMethod($methodName)) {
                 continue;
             }
 
-            return $parentClassReflection->getNativeMethod($methodName);
+            return $interfaceReflection->getNativeMethod($methodName);
         }
 
         return null;