[Php80] Preserve int key defined not start from 0 on AnnotationToAttr…

…ibuteRector (#2735)

packages/PhpAttribute/AnnotationToAttributeMapper/CurlyListNodeAnnotationToAttributeMapper.php

@@ -7,6 +7,7 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\Array_;
 use PhpParser\Node\Expr\ArrayItem;
+use PhpParser\Node\Scalar\LNumber;
 use Rector\BetterPhpDocParser\ValueObject\PhpDoc\DoctrineAnnotation\CurlyListNode;
 use Rector\PhpAttribute\AnnotationToAttributeMapper;
 use Rector\PhpAttribute\Contract\AnnotationToAttributeMapperInterface;
@@ -41,7 +42,10 @@ public function isCandidate(mixed $value): bool
     public function map($value): Array_
     {
         $arrayItems = [];
-        foreach ($value->getValuesWithExplicitSilentAndWithoutQuotes() as $key => $singleValue) {
+        $valuesWithExplicitSilent = $value->getValuesWithExplicitSilentAndWithoutQuotes();
+        $loop = -1;
+
+        foreach ($valuesWithExplicitSilent as $key => $singleValue) {
             $valueExpr = $this->annotationToAttributeMapper->map($singleValue);
 
             // remove node
@@ -51,10 +55,15 @@ public function map($value): Array_
 
             Assert::isInstanceOf($valueExpr, Expr::class);
 
-            $keyExpr = null;
             if (! is_int($key)) {
                 $keyExpr = $this->annotationToAttributeMapper->map($key);
                 Assert::isInstanceOf($keyExpr, Expr::class);
+            } else {
+                ++$loop;
+
+                $keyExpr = $loop !== $key
+                    ? new LNumber($key)
+                    : null;
             }
 
             $arrayItems[] = new ArrayItem($valueExpr, $keyExpr);

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/Fixture/Doctrine/preserve_int_key_defined.php.inc

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture\Doctrine;
+
+use Doctrine\ORM\Mapping as ORM;
+
+/**
+ * @ORM\DiscriminatorMap({ "1" = "CostDetailEntity" })
+ */
+class PreserveIntKeyDefined
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\AnnotationToAttributeRector\Fixture\Doctrine;
+
+use Doctrine\ORM\Mapping as ORM;
+
+#[ORM\DiscriminatorMap([1 => 'CostDetailEntity'])]
+class PreserveIntKeyDefined
+{
+}
+
+?>

rules-tests/Php80/Rector/Class_/AnnotationToAttributeRector/config/configured_rule.php

@@ -36,6 +36,7 @@
             new AnnotationToAttribute('Doctrine\ORM\Mapping\UniqueConstraint'),
             new AnnotationToAttribute('Doctrine\ORM\Mapping\JoinColumns'),
             new AnnotationToAttribute('Doctrine\ORM\Mapping\JoinColumn'),
+            new AnnotationToAttribute('Doctrine\ORM\Mapping\DiscriminatorMap'),
 
             // validation
             new AnnotationToAttribute('Symfony\Component\Validator\Constraints\All'),