[EarlyReturn] Skip indirect return with define variable after parent …

…else on ChangeAndIfToEarlyReturnRector (#2836)

* Add failing test fixture for ChangeAndIfToEarlyReturnRector

# Failing Test for ChangeAndIfToEarlyReturnRector

Based on https://getrector.org/demo/5cf285f8-b9ba-40f6-bd8c-7c325bb2458d

* update fixture

* update

* Closes #2823 Fixes rectorphp/rector#7413

* [ci-review] Rector Rectify

Co-authored-by: Shin <2082119+shinsenter@users.noreply.github.com>
Co-authored-by: GitHub Action <action@github.com>

rules-tests/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector/Fixture/skip_variable_defined_next_parent_else.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+function dummy_wrap($maxWidth, $text)
+{
+    if (get_font_set()) {
+    } else {
+        $nb = strlen($s);
+
+        if ($nb > 0 && $s[$nb - 1] == "\n") {
+            $nb--;
+        }
+    }
+
+    $nl  = 1;
+
+    return $nl;
+}
+
+?>

rules/EarlyReturn/Rector/If_/ChangeAndIfToEarlyReturnRector.php

@@ -248,6 +248,12 @@ private function shouldSkip(StmtsAwareInterface $stmtsAware, If_ $if, ?Stmt $nex
     private function isParentIfReturnsVoidOrParentIfHasNextNode(StmtsAwareInterface $stmtsAware): bool
     {
         if (! $stmtsAware instanceof If_) {
+            $parent = $stmtsAware->getAttribute(AttributeKey::PARENT_NODE);
+            if ($parent instanceof If_) {
+                $node = $parent->getAttribute(AttributeKey::NEXT_NODE);
+                return ! $node instanceof Return_;
+            }
+
             return false;
         }