[CodeQuality][Performance] Using STOP_TRAVERSAL in traverseNodesWithC…

…allable() in LocallyCalledStaticMethodToNonStaticRector (#4278)
rectorphp · Jun 18, 2023 · c8e7963 · c8e7963
1 parent 33cfa4f
commit c8e7963
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/rules/CodeQuality/Rector/ClassMethod/LocallyCalledStaticMethodToNonStaticRector.php b/rules/CodeQuality/Rector/ClassMethod/LocallyCalledStaticMethodToNonStaticRector.php
@@ -10,6 +10,7 @@
 use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Stmt\Class_;
 use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\NodeTraverser;
 use PHPStan\Reflection\ClassReflection;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Core\Reflection\ReflectionResolver;
@@ -164,7 +165,7 @@ private function isClassMethodCalledInAnotherStaticClassMethod(Class_ $class, Cl
             $this->traverseNodesWithCallable($checkedClassMethod, function (Node $node) use (
                 $currentClassMethodName,
                 &$isInsideStaticClassMethod
-            ): ?StaticCall {
+            ): ?int {
                 if (! $node instanceof StaticCall) {
                     return null;
                 }
@@ -178,7 +179,7 @@ private function isClassMethodCalledInAnotherStaticClassMethod(Class_ $class, Cl
                 }
 
                 $isInsideStaticClassMethod = true;
-                return $node;
+                return NodeTraverser::STOP_TRAVERSAL;
             });
 
             if ($isInsideStaticClassMethod) {