Revert "[Performance] Immediate remove UnreachableStatementNodeVisito…

…r object after traverse to avoid re-use in next file (#4417)" (#4418) This reverts commit 24ce37d.
rectorphp · Jul 4, 2023 · cd3d327 · cd3d327
1 parent 24ce37d
commit cd3d327
Showing 1 changed file with 6 additions and 15 deletions.
diff --git a/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php b/packages/NodeTypeResolver/NodeScopeAndMetadataDecorator.php
@@ -48,22 +48,13 @@ public function decorateNodesFromFile(File $file, array $stmts): array
         $stmts = $this->phpStanNodeScopeResolver->processNodes($stmts, $file->getFilePath());
 
         if ($this->phpStanNodeScopeResolver->hasUnreachableStatementNode()) {
-            $unreachableStatementNodeVisitor = new UnreachableStatementNodeVisitor(
-                $this->phpStanNodeScopeResolver,
-                $file->getFilePath(),
-                $this->scopeFactory
+            $this->nodeTraverser->addVisitor(
+                new UnreachableStatementNodeVisitor(
+                    $this->phpStanNodeScopeResolver,
+                    $file->getFilePath(),
+                    $this->scopeFactory
+                )
             );
-            $this->nodeTraverser->addVisitor($unreachableStatementNodeVisitor);
-
-            $stmts = $this->nodeTraverser->traverse($stmts);
-
-            /**
-             * immediate remove UnreachableStatementNodeVisitor after traverse to avoid
-             * re-used in nodeTraverser property in next file
-             */
-            $this->nodeTraverser->removeVisitor($unreachableStatementNodeVisitor);
-
-            return $stmts;
         }
 
         return $this->nodeTraverser->traverse($stmts);