Remove rule DataProviderArrayItemsNewlinedRector.php (#5227)

Co-authored-by: Erison Silva <erison.silva@power.cloud>
rectorphp · Nov 7, 2023 · ce62c63 · ce62c63
1 parent 6d80745
commit ce62c63
Show file tree

Hide file tree

Showing 10 changed files with 5 additions and 304 deletions.
diff --git a/build/target-repository/docs/rector_rules_overview.md b/build/target-repository/docs/rector_rules_overview.md
@@ -1,4 +1,4 @@
-# 356 Rules Overview
+# 355 Rules Overview
 
 <br>
 
@@ -8,7 +8,7 @@
 
 - [CodeQuality](#codequality) (72)
 
-- [CodingStyle](#codingstyle) (29)
+- [CodingStyle](#codingstyle) (28)
 
 - [DeadCode](#deadcode) (42)
 
@@ -1720,38 +1720,6 @@ Change count array comparison to empty array comparison to improve performance
 
 <br>
 
-### DataProviderArrayItemsNewlinedRector
-
-Change data provider in PHPUnit test case to newline per item
-
-- class: [`Rector\CodingStyle\Rector\ClassMethod\DataProviderArrayItemsNewlinedRector`](../rules/CodingStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector.php)
-
-```diff
- use PHPUnit\Framework\TestCase;
-
- final class ImageBinaryTest extends TestCase
- {
-     /**
-      * @dataProvider provideData()
-      */
-     public function testGetBytesSize(string $content, int $number): void
-     {
-         // ...
-     }
-
-     public static function provideData(): array
-     {
--        return [['content', 8], ['content123', 11]];
-+        return [
-+            ['content', 8],
-+            ['content123', 11]
-+        ];
-     }
- }
-```
-
-<br>
-
 ### EncapsedStringsToSprintfRector
 
 Convert enscaped {$string} to more readable sprintf or concat, if no mask is used

diff --git a/...sMethod/DataProviderArrayItemsNewlinedRector/DataProviderArrayItemsNewlinedRectorTest.php b/...sMethod/DataProviderArrayItemsNewlinedRector/DataProviderArrayItemsNewlinedRectorTest.php
diff --git a/...yle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/skip_no_array.php.inc b/...yle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/skip_no_array.php.inc
diff --git a/.../Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/skip_non_phpunit.php.inc b/.../Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/skip_non_phpunit.php.inc
diff --git a/.../Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/skip_test_method.php.inc b/.../Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/skip_test_method.php.inc
diff --git a/...gStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/some_class.php.inc b/...gStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/Fixture/some_class.php.inc
diff --git a/...gStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/config/configured_rule.php b/...gStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector/config/configured_rule.php
diff --git a/rules/CodingStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector.php b/rules/CodingStyle/Rector/ClassMethod/DataProviderArrayItemsNewlinedRector.php
diff --git a/rules/CodingStyle/Rector/If_/NullableCompareToNullRector.php b/rules/CodingStyle/Rector/If_/NullableCompareToNullRector.php
@@ -82,7 +82,7 @@ private function isNullableNonScalarType(Expr $expr): bool
         $nativeType = $this->nodeTypeResolver->getNativeType($expr);
 
         // is non-nullable?
-        if (!TypeCombinator::containsNull($nativeType)) {
+        if (! TypeCombinator::containsNull($nativeType)) {
             return false;
         }
 
@@ -98,6 +98,7 @@ private function isNullableNonScalarType(Expr $expr): bool
         }
 
         $nativeType = TypeCombinator::removeNull($nativeType);
-        return !$nativeType->isScalar()->yes();
+        return ! $nativeType->isScalar()
+            ->yes();
     }
 }
diff --git a/utils/Command/MissingInSetCommand.php b/utils/Command/MissingInSetCommand.php
@@ -5,7 +5,6 @@
 namespace Rector\Utils\Command;
 
 use Nette\Utils\Strings;
-use Rector\CodingStyle\Rector\ClassMethod\DataProviderArrayItemsNewlinedRector;
 use Rector\CodingStyle\Rector\Switch_\BinarySwitchToIfElseRector;
 use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
 use Rector\Php71\Rector\FuncCall\CountOnNullRector;
@@ -31,7 +30,6 @@ final class MissingInSetCommand extends Command
         ConfigurableRectorInterface::class,
         DeclareStrictTypesRector::class,
         // optional
-        DataProviderArrayItemsNewlinedRector::class,
         BinaryOpNullableToInstanceofRector::class,
         WhileNullableToInstanceofRector::class,
         // collectors