[DeadCode] Handle native function call not exists in RemoveUnusedPriv…

…atePropertyRector (#72)

* [DeadCode] Handle native function call not exists in RemoveUnusedPrivatePropertyRector

* phpstan

* [ci-review] Rector Rectify

Co-authored-by: kaizen-ci <info@kaizen-ci.org>

packages/ReadWrite/Guard/VariableToConstantGuard.php

@@ -73,7 +73,12 @@ private function resolveFunctionReferencePositions(FunctionReflection $functionR
 
         // this is needed, as native function reflection does not have access to referenced parameters
         if ($functionReflection instanceof NativeFunctionReflection) {
-            $nativeFunctionReflection = new ReflectionFunction($functionReflection->getName());
+            $functionName = $functionReflection->getName();
+            if (! function_exists($functionName)) {
+                return [];
+            }
+
+            $nativeFunctionReflection = new ReflectionFunction($functionName);
         } else {
             $nativeFunctionReflection = $this->privatesAccessor->getPrivateProperty($functionReflection, 'reflection');
         }

phpstan.neon

@@ -448,7 +448,9 @@ parameters:
 
         -
             message: '#Function "function_exists\(\)" cannot be used/left in the code#'
-            path: src/functions/node_helper.php
+            paths:
+                 - src/functions/node_helper.php
+                 - packages/ReadWrite/Guard/VariableToConstantGuard.php
 
         # upgrade to PHP 7.4 wip
         - '#This property type might be inlined to PHP\. Do you have confidence it is correct\? Put it here#'

rules-tests/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector/Fixture/native_function_call_not_exists.php.inc

@@ -0,0 +1,30 @@
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector\Fixture;
+
+class NativeFunctionCallNotExists
+{
+    private $resultID;
+    private $rowOffset;
+    public function getFieldCount(): int
+	{
+		return sqlsrv_num_fields($this->resultID);
+	}
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\DeadCode\Rector\Property\RemoveUnusedPrivatePropertyRector\Fixture;
+
+class NativeFunctionCallNotExists
+{
+    private $resultID;
+    public function getFieldCount(): int
+	{
+		return sqlsrv_num_fields($this->resultID);
+	}
+}
+
+?>