Support class-const-fetch in ReturnTypeFromStrictTypedCallRector (#4520)

* Support class-const-fetch in ReturnTypeFromStrictTypedCallRector

* Create skip_unknown_constant_int_returns.php.inc

* Update skip_unknown_constant_int_returns.php.inc

* Create skip_wrong_typed_constant.php.inc

* Create wrong_typed_constant_returns.php.inc

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/same_typed_constant_int_returns.php.inc

@@ -0,0 +1,49 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class SameTypedIntConstantReturns
+{
+    const INT = 0;
+
+    public function getData()
+    {
+        if (rand(0,1)) {
+            return self::INT;
+        }
+
+        return $this->getInt();
+    }
+
+    public function getInt(): int
+    {
+
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class SameTypedIntConstantReturns
+{
+    const INT = 0;
+
+    public function getData(): int
+    {
+        if (rand(0,1)) {
+            return self::INT;
+        }
+
+        return $this->getInt();
+    }
+
+    public function getInt(): int
+    {
+
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/skip_unknown_constant_int_returns.php.inc

@@ -0,0 +1,22 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class SkipUnknownConstantIntReturns
+{
+    public function getData()
+    {
+        if (rand(0,1)) {
+            return self::NOT_DEFINED;
+        }
+
+        return $this->getInt();
+    }
+
+    public function getInt(): int
+    {
+
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/skip_wrong_typed_constant.php.inc

@@ -0,0 +1,24 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class SkipWrongTypedConstant
+{
+    const STRING = 'hello';
+
+    public function getData()
+    {
+        if (rand(0,1)) {
+            return self::STRING;
+        }
+
+        return $this->getInt();
+    }
+
+    public function getInt(): int
+    {
+
+    }
+}
+
+?>

rules-tests/TypeDeclaration/Rector/ClassMethod/ReturnTypeFromStrictTypedCallRector/Fixture/wrong_typed_constant_returns.php.inc

@@ -0,0 +1,55 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class WrongTypedIntConstant
+{
+    /**
+     * @var string
+     */
+    const WRONG_TYPED = 0;
+
+    public function getData()
+    {
+        if (rand(0,1)) {
+            return self::WRONG_TYPED;
+        }
+
+        return $this->getInt();
+    }
+
+    public function getInt(): int
+    {
+
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector\Fixture;
+
+final class WrongTypedIntConstant
+{
+    /**
+     * @var string
+     */
+    const WRONG_TYPED = 0;
+
+    public function getData(): int
+    {
+        if (rand(0,1)) {
+            return self::WRONG_TYPED;
+        }
+
+        return $this->getInt();
+    }
+
+    public function getInt(): int
+    {
+
+    }
+}
+
+?>

rules/TypeDeclaration/TypeAnalyzer/ReturnStrictTypeAnalyzer.php

@@ -54,6 +54,8 @@ public function collectStrictReturnTypes(array $returns, Scope $scope): array
             if ($returnedExpr instanceof MethodCall || $returnedExpr instanceof StaticCall || $returnedExpr instanceof FuncCall) {
                 $containsStrictCall = true;
                 $returnNode = $this->resolveMethodCallReturnNode($returnedExpr);
+            } elseif ($returnedExpr instanceof Expr\ClassConstFetch) {
+                $returnNode = $this->resolveConstFetchReturnNode($returnedExpr, $scope);
             } elseif (
                 $returnedExpr instanceof Array_
                 || $returnedExpr instanceof String_
@@ -106,4 +108,15 @@ private function resolveLiteralReturnNode(Array_|Scalar $returnedExpr, Scope $sc
         $returnType = $scope->getType($returnedExpr);
         return $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($returnType, TypeKind::RETURN);
     }
+
+    private function resolveConstFetchReturnNode(Expr\ClassConstFetch $returnedExpr, Scope $scope): ?Node
+    {
+        $constType = $scope->getType($returnedExpr);
+
+        if ($constType instanceof MixedType) {
+            return null;
+        }
+
+        return $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($constType, TypeKind::RETURN);
+    }
 }