[Performance] Remove loop $newStmts on BetterNodeFinder (#3889)

* [Performance] Remove loop $newStmts on BetterNodeFinder * clean up
rectorphp · May 18, 2023 · cee58fb · cee58fb
1 parent 24f8610
commit cee58fb
Showing 1 changed file with 2 additions and 15 deletions.
diff --git a/src/PhpParser/Node/BetterNodeFinder.php b/src/PhpParser/Node/BetterNodeFinder.php
@@ -637,22 +637,9 @@ private function resolveNodeFromFile(array $newStmts, Node $node, bool $isPrevio
         }
 
         $currentStmtKey = $node->getAttribute(AttributeKey::STMT_KEY);
-        foreach ($newStmts as $key => $newStmt) {
-            $stmtKey = $newStmt->getAttribute(AttributeKey::STMT_KEY);
-            if ($stmtKey !== $currentStmtKey) {
-                continue;
-            }
-
-            if ($key !== $currentStmtKey) {
-                continue;
-            }
-
-            return $isPrevious
-                ? ($newStmts[$key - 1] ?? null)
-                : ($newStmts[$key + 1] ?? null);
-        }
+        $stmtKey = $isPrevious ? $currentStmtKey - 1 : $currentStmtKey + 1;
 
-        return null;
+        return $newStmts[$stmtKey] ?? null;
     }
 
     /**