[CodingStyle] Trigger RemoveFinalFromConstRector (#1733)

* [CodingStyle] Trigger RemoveFinalFromConstRector * [ci-review] Rector Rectify * [ci-review] Rector Rectify * [ci-review] Rector Rectify Co-authored-by: GitHub Action <action@github.com>
rectorphp · Jan 26, 2022 · cfd0d61 · cfd0d61
1 parent 15e28c6
commit cfd0d61
Show file tree

Hide file tree

Showing 122 changed files with 432 additions and 432 deletions.
diff --git a/packages/BetterPhpDocParser/PhpDocParser/PhpDocFromTypeDeclarationDecorator.php b/packages/BetterPhpDocParser/PhpDocParser/PhpDocFromTypeDeclarationDecorator.php
@@ -33,12 +33,12 @@ final class PhpDocFromTypeDeclarationDecorator
     /**
      * @var class-string<ReturnTypeWillChange>
      */
-    final public const RETURN_TYPE_WILL_CHANGE_ATTRIBUTE = 'ReturnTypeWillChange';
+    public const RETURN_TYPE_WILL_CHANGE_ATTRIBUTE = 'ReturnTypeWillChange';
 
     /**
      * @var array<string, array<string, string[]>>
      */
-    final public const ADD_RETURN_TYPE_WILL_CHANGE = [
+    public const ADD_RETURN_TYPE_WILL_CHANGE = [
         'PHPStan\Type\MixedType' => [
             'ArrayAccess' => ['offsetGet'],
         ],

diff --git a/packages/BetterPhpDocParser/Printer/PhpDocInfoPrinter.php b/packages/BetterPhpDocParser/Printer/PhpDocInfoPrinter.php
@@ -34,7 +34,7 @@ final class PhpDocInfoPrinter
      * @var string
      * @see https://regex101.com/r/Ab0Vey/1
      */
-    final public const CLOSING_DOCBLOCK_REGEX = '#\*\/(\s+)?$#';
+    public const CLOSING_DOCBLOCK_REGEX = '#\*\/(\s+)?$#';
 
     /**
      * @var string

diff --git a/packages/BetterPhpDocParser/ValueObject/DoctrineAnnotation/SilentKeyMap.php b/packages/BetterPhpDocParser/ValueObject/DoctrineAnnotation/SilentKeyMap.php
@@ -9,7 +9,7 @@ final class SilentKeyMap
     /**
      * @var array<string, string>
      */
-    final public const CLASS_NAMES_TO_SILENT_KEYS = [
+    public const CLASS_NAMES_TO_SILENT_KEYS = [
         'Symfony\Component\Routing\Annotation\Route' => 'path',
     ];
 }
diff --git a/packages/BetterPhpDocParser/ValueObject/NodeTypes.php b/packages/BetterPhpDocParser/ValueObject/NodeTypes.php
@@ -17,7 +17,7 @@ final class NodeTypes
     /**
      * @var array<class-string<PhpDocTagValueNode>>
      */
-    final public const TYPE_AWARE_NODES = [
+    public const TYPE_AWARE_NODES = [
         VarTagValueNode::class,
         ParamTagValueNode::class,
         ReturnTagValueNode::class,
@@ -29,7 +29,7 @@ final class NodeTypes
     /**
      * @var string[]
      */
-    final public const TYPE_AWARE_DOCTRINE_ANNOTATION_CLASSES = [
+    public const TYPE_AWARE_DOCTRINE_ANNOTATION_CLASSES = [
         'JMS\Serializer\Annotation\Type',
         'Doctrine\ORM\Mapping\OneToMany',
         'Symfony\Component\Validator\Constraints\Choice',

diff --git a/packages/BetterPhpDocParser/ValueObject/PhpDocAttributeKey.php b/packages/BetterPhpDocParser/ValueObject/PhpDocAttributeKey.php
@@ -11,26 +11,26 @@ final class PhpDocAttributeKey
     /**
      * @var string
      */
-    final public const START_AND_END = 'start_and_end';
+    public const START_AND_END = 'start_and_end';
 
     /**
      * Fully qualified name of identifier type class
      * @var string
      */
-    final public const RESOLVED_CLASS = 'resolved_class';
+    public const RESOLVED_CLASS = 'resolved_class';
 
     /**
      * @var string
      */
-    final public const PARENT = NativePhpDocAttributeKey::PARENT;
+    public const PARENT = NativePhpDocAttributeKey::PARENT;
 
     /**
      * @var string
      */
-    final public const LAST_PHP_DOC_TOKEN_POSITION = 'last_token_position';
+    public const LAST_PHP_DOC_TOKEN_POSITION = 'last_token_position';
 
     /**
      * @var string
      */
-    final public const ORIG_NODE = NativePhpDocAttributeKey::ORIG_NODE;
+    public const ORIG_NODE = NativePhpDocAttributeKey::ORIG_NODE;
 }
diff --git a/packages/Caching/Enum/CacheKey.php b/packages/Caching/Enum/CacheKey.php
@@ -12,15 +12,15 @@ final class CacheKey
     /**
      * @var string
      */
-    final public const CONFIGURATION_HASH_KEY = 'configuration_hash';
+    public const CONFIGURATION_HASH_KEY = 'configuration_hash';
 
     /**
      * @var string
      */
-    final public const FILE_HASH_KEY = 'file_hash';
+    public const FILE_HASH_KEY = 'file_hash';
 
     /**
      * @var string
      */
-    final public const DEPENDENT_FILES_KEY = 'dependency_files_key';
+    public const DEPENDENT_FILES_KEY = 'dependency_files_key';
 }
diff --git a/packages/ChangesReporting/Output/ConsoleOutputFormatter.php b/packages/ChangesReporting/Output/ConsoleOutputFormatter.php
@@ -18,7 +18,7 @@ final class ConsoleOutputFormatter implements OutputFormatterInterface
     /**
      * @var string
      */
-    final public const NAME = 'console';
+    public const NAME = 'console';
 
     /**
      * @var string

diff --git a/packages/ChangesReporting/Output/JsonOutputFormatter.php b/packages/ChangesReporting/Output/JsonOutputFormatter.php
@@ -16,7 +16,7 @@ final class JsonOutputFormatter implements OutputFormatterInterface
     /**
      * @var string
      */
-    final public const NAME = 'json';
+    public const NAME = 'json';
 
     public function __construct(
         private readonly RectorsChangelogResolver $rectorsChangelogResolver

diff --git a/packages/Comments/NodeDocBlock/DocBlockUpdater.php b/packages/Comments/NodeDocBlock/DocBlockUpdater.php
@@ -16,7 +16,7 @@ final class DocBlockUpdater
      * @var string
      * @see https://regex101.com/r/VdaVGL/1
      */
-    final public const SPACE_OR_ASTERISK_REGEX = '#(\s|\*)+#';
+    public const SPACE_OR_ASTERISK_REGEX = '#(\s|\*)+#';
 
     public function __construct(
         private readonly PhpDocInfoPrinter $phpDocInfoPrinter

diff --git a/packages/FileFormatter/ValueObject/EditorConfigOption.php b/packages/FileFormatter/ValueObject/EditorConfigOption.php
@@ -9,25 +9,25 @@ final class EditorConfigOption
     /**
      * @var string
      */
-    final public const INDENT_STYLE = 'indent_style';
+    public const INDENT_STYLE = 'indent_style';
 
     /**
      * @var string
      */
-    final public const INDENT_SIZE = 'indent_size';
+    public const INDENT_SIZE = 'indent_size';
 
     /**
      * @var string
      */
-    final public const END_OF_LINE = 'end_of_line';
+    public const END_OF_LINE = 'end_of_line';
 
     /**
      * @var string
      */
-    final public const INSERT_FINAL_NEWLINE = 'insert_final_newline';
+    public const INSERT_FINAL_NEWLINE = 'insert_final_newline';
 
     /**
      * @var string
      */
-    final public const TAB_WIDTH = 'tab_width';
+    public const TAB_WIDTH = 'tab_width';
 }
diff --git a/packages/FileFormatter/ValueObject/Indent.php b/packages/FileFormatter/ValueObject/Indent.php
@@ -19,7 +19,7 @@ final class Indent implements Stringable
     /**
      * @var array<string, string>
      */
-    final public const CHARACTERS = [
+    public const CHARACTERS = [
         self::SPACE => ' ',
         self::TAB => "\t",
     ];

diff --git a/packages/FileFormatter/ValueObject/NewLine.php b/packages/FileFormatter/ValueObject/NewLine.php
@@ -17,17 +17,17 @@ final class NewLine implements Stringable
     /**
      * @var string
      */
-    final public const LINE_FEED = 'lf';
+    public const LINE_FEED = 'lf';
 
     /**
      * @var string
      */
-    final public const CARRIAGE_RETURN = 'cr';
+    public const CARRIAGE_RETURN = 'cr';
 
     /**
      * @var string
      */
-    final public const CARRIAGE_RETURN_LINE_FEED = 'crlf';
+    public const CARRIAGE_RETURN_LINE_FEED = 'crlf';
 
     /**
      * @var array<string, string>

diff --git a/packages/NodeNestingScope/ValueObject/ControlStructure.php b/packages/NodeNestingScope/ValueObject/ControlStructure.php
@@ -27,7 +27,7 @@ final class ControlStructure
     /**
      * @var array<class-string<FunctionLike>>
      */
-    final public const RETURN_ISOLATING_SCOPE_NODE_TYPES = [
+    public const RETURN_ISOLATING_SCOPE_NODE_TYPES = [
         Function_::class,
         ClassMethod::class,
         Closure::class,
@@ -37,7 +37,7 @@ final class ControlStructure
     /**
      * @var array<class-string<Node>>
      */
-    final public const BREAKING_SCOPE_NODE_TYPES = [
+    public const BREAKING_SCOPE_NODE_TYPES = [
         For_::class,
         Foreach_::class,
         If_::class,
@@ -54,7 +54,7 @@ final class ControlStructure
      * These situations happens only if condition is met
      * @var array<class-string<Node>>
      */
-    final public const CONDITIONAL_NODE_SCOPE_TYPES = [
+    public const CONDITIONAL_NODE_SCOPE_TYPES = [
         If_::class,
         While_::class,
         Do_::class,