Skip to content

Commit

Permalink
[TypeDeclaration] Remove parent lookup on AllAssignNodePropertyTypeIn…
Browse files Browse the repository at this point in the history
…ferer (#4264)

* [TypeDeclaration] Remove parent lookup on AllAssignNodePropertyTypeInferer

* Fix phpstan
  • Loading branch information
samsonasik committed Jun 17, 2023
1 parent 5f976fa commit d036eeb
Showing 1 changed file with 10 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@

use PhpParser\Node\Stmt\ClassLike;
use PhpParser\Node\Stmt\Property;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Type\Type;
use Rector\Core\PhpParser\Node\BetterNodeFinder;
use Rector\Core\PhpParser\ClassLikeAstResolver;
use Rector\Core\Reflection\ReflectionResolver;
use Rector\NodeNameResolver\NodeNameResolver;
use Rector\TypeDeclaration\TypeInferer\AssignToPropertyTypeInferer;

Expand All @@ -16,18 +18,22 @@ final class AllAssignNodePropertyTypeInferer
public function __construct(
private readonly AssignToPropertyTypeInferer $assignToPropertyTypeInferer,
private readonly NodeNameResolver $nodeNameResolver,
private readonly BetterNodeFinder $betterNodeFinder
private readonly ReflectionResolver $reflectionResolver,
private readonly ClassLikeAstResolver $classLikeAstResolver
) {
}

public function inferProperty(Property $property): ?Type
{
$classLike = $this->betterNodeFinder->findParentType($property, ClassLike::class);
if (! $classLike instanceof ClassLike) {
$classReflection = $this->reflectionResolver->resolveClassReflection($property);
if (! $classReflection instanceof ClassReflection) {
return null;
}

/** @var ClassLike $classLike */
$classLike = $this->classLikeAstResolver->resolveClassFromClassReflection($classReflection);
$propertyName = $this->nodeNameResolver->getName($property);

return $this->assignToPropertyTypeInferer->inferPropertyInClassLike($property, $propertyName, $classLike);
}
}

0 comments on commit d036eeb

Please sign in to comment.