[Core] Early assign $smartFileInfo->getPathname() to variable for Rem…

…ovedAndAddedFilesCollector::isFileRemoved() (#256) * [Core] Early assign $smartFileInfo->getPathname() to variable for RemovedAndAddedFilesCollector::isFileRemoved() * [ci-review] Rector Rectify Co-authored-by: GitHub Action <action@github.com>
rectorphp · Jun 20, 2021 · d0e6a3b · d0e6a3b
1 parent b62161e
commit d0e6a3b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/Application/FileSystem/RemovedAndAddedFilesCollector.php b/src/Application/FileSystem/RemovedAndAddedFilesCollector.php
@@ -36,8 +36,13 @@ public function getRemovedFiles(): array
 
     public function isFileRemoved(SmartFileInfo $smartFileInfo): bool
     {
+        if ($this->removedFileInfos === []) {
+            return false;
+        }
+
+        $pathname = $smartFileInfo->getPathname();
         foreach ($this->removedFileInfos as $removedFileInfo) {
-            if ($removedFileInfo->getPathname() !== $smartFileInfo->getPathname()) {
+            if ($removedFileInfo->getPathname() !== $pathname) {
                 continue;
             }