Fix StrictArrayParamDimFetchRector on same named property (#4488)

* Fix StrictArrayParamDimFetchRector on array append * fix * Update skip_same_name_property_append.php.inc
rectorphp · Jul 12, 2023 · d514a5a · d514a5a
1 parent d4be167
commit d514a5a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/...ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_same_name_property_append.php.inc b/...ClassMethod/StrictArrayParamDimFetchRector/Fixture/skip_same_name_property_append.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ClassMethod\StrictArrayParamDimFetchRector\Fixture;
+
+final class SkipSameNamePropertyFetch
+{
+    public function addSuccessMessage($success)
+    {
+        $this->success[] = $success;
+    }
+}
diff --git a/rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php b/rules/TypeDeclaration/Rector/ClassMethod/StrictArrayParamDimFetchRector.php
@@ -7,6 +7,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\ArrayDimFetch;
 use PhpParser\Node\Expr\FuncCall;
+use PhpParser\Node\Expr\Variable;
 use PhpParser\Node\Identifier;
 use PhpParser\Node\Param;
 use PhpParser\Node\Stmt\ClassMethod;
@@ -115,6 +116,10 @@ private function isParamAccessedArrayDimFetch(Param $param, ClassMethod|Function
                 return null;
             }
 
+            if (!$node->var instanceof Variable) {
+                return null;
+            }
+
             if (! $this->isName($node->var, $paramName)) {
                 return null;
             }