[Php71] Skip re-assign as string on AssignArrayToStringRector (#5659)

* [Php71] Skip re-assign as string on AssignArrayToStringRector

* fixture

* [ci-review] Rector Rectify

* [Php71] Skip re-assign as string on AssignArrayToStringRector

---------

Co-authored-by: GitHub Action <actions@github.com>

rules-tests/Php71/Rector/Assign/AssignArrayToStringRector/Fixture/skip_reassigned_as_string.php.inc

@@ -0,0 +1,21 @@
+<?php
+
+namespace Rector\Tests\Php71\Rector\Assign\AssignArrayToStringRector\Fixture;
+
+final class SkipReAssignedAsString
+{
+    public function fun($cdate)
+    {
+        if ($cdate) {
+            $where[] = 'n.sometable <= 1000';
+        }
+
+        if (empty($where)) {
+            $where = '';
+        } else {
+            $where = 'WHERE ' . implode(' AND ', $where);
+        }
+
+        $sql = 'SELECT something, something FROM table1' . $where;
+    }
+}

rules/Php71/Rector/Assign/AssignArrayToStringRector.php

@@ -237,11 +237,15 @@ private function refactorAssign(
         Assign $assign,
         Namespace_|FileWithoutNamespace|ClassMethod|Function_|Closure $node
     ): ?Assign {
+        if (! $assign->var instanceof Variable) {
+            return null;
+        }
+
         if (! $this->isEmptyString($assign->expr)) {
             return null;
         }
 
-        if (! $assign->var instanceof Variable) {
+        if ($this->nodeTypeResolver->getNativeType($assign->var)->isArray()->yes()) {
             return null;
         }