NarrowUnionTypeDocRector should skip literal strings (#763)

rectorphp · Aug 26, 2021 · d8a6725 · d8a6725
1 parent 47ad54d
commit d8a6725
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 1 deletion.
diff --git a/packages/PHPStanStaticTypeMapper/TypeAnalyzer/UnionTypeAnalyzer.php b/packages/PHPStanStaticTypeMapper/TypeAnalyzer/UnionTypeAnalyzer.php
@@ -6,6 +6,7 @@
 
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\BooleanType;
+use PHPStan\Type\Constant\ConstantStringType;
 use PHPStan\Type\FloatType;
 use PHPStan\Type\IntegerType;
 use PHPStan\Type\IterableType;
@@ -102,7 +103,7 @@ public function isScalar(UnionType $unionType): bool
         }
 
         foreach ($types as $type) {
-            if ($type instanceof StringType) {
+            if ($type instanceof StringType && !$type instanceof ConstantStringType) {
                 continue;
             }
             if ($type instanceof FloatType) {

diff --git a/...deQuality/Rector/ClassMethod/NarrowUnionTypeDocRector/Fixture/skip_constant_union.php.inc b/...deQuality/Rector/ClassMethod/NarrowUnionTypeDocRector/Fixture/skip_constant_union.php.inc
@@ -0,0 +1,20 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\NarrowUnionTypeDocRector\Fixture;
+
+class SkipConstantUnion
+{
+    public const A = 'a';
+    public const B = 'b';
+    public const C = 'c';
+    public const D = 'd';
+
+    /**
+     * @param self::* $value
+     */
+    public function run(string $value): void
+    {
+    }
+}
+
+?>
diff --git a/...odeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector/Fixture/skip_literal_union.php.inc b/...odeQuality/Rector/ClassMethod/NarrowUnionTypeDocRector/Fixture/skip_literal_union.php.inc
@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\ClassMethod\NarrowUnionTypeDocRector\Fixture;
+
+class SkipLiteralUnion
+{
+    /**
+     * @param 'a'|'b'|'c'|'d' $value
+     */
+    public function run(string $value): void
+    {
+    }
+}
+
+?>