[Core] Remove RenamedClassesSourceLocator (#3454)

packages/NodeTypeResolver/PHPStan/Scope/PHPStanNodeScopeResolver.php

@@ -35,11 +35,7 @@
 use PHPStan\Analyser\MutatingScope;
 use PHPStan\Analyser\NodeScopeResolver;
 use PHPStan\Analyser\ScopeContext;
-use PHPStan\BetterReflection\Reflector\Reflector;
-use PHPStan\BetterReflection\SourceLocator\Type\AggregateSourceLocator;
-use PHPStan\BetterReflection\SourceLocator\Type\SourceLocator;
 use PHPStan\Node\UnreachableStatementNode;
-use PHPStan\Reflection\BetterReflection\Reflector\MemoizingReflector;
 use PHPStan\Reflection\ClassReflection;
 use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Type\ObjectType;
@@ -49,7 +45,6 @@
 use Rector\Core\Exception\ShouldNotHappenException;
 use Rector\Core\NodeAnalyzer\ClassAnalyzer;
 use Rector\Core\PhpParser\Node\BetterNodeFinder;
-use Rector\Core\StaticReflection\SourceLocator\RenamedClassesSourceLocator;
 use Rector\Core\Util\Reflection\PrivatesAccessor;
 use Rector\NodeNameResolver\NodeNameResolver;
 use Rector\NodeTypeResolver\Node\AttributeKey;
@@ -75,12 +70,10 @@ public function __construct(
         private readonly RemoveDeepChainMethodCallNodeVisitor $removeDeepChainMethodCallNodeVisitor,
         private readonly ScopeFactory $scopeFactory,
         private readonly PrivatesAccessor $privatesAccessor,
-        private readonly RenamedClassesSourceLocator $renamedClassesSourceLocator,
         private readonly NodeNameResolver $nodeNameResolver,
         private readonly BetterNodeFinder $betterNodeFinder,
         private readonly ClassAnalyzer $classAnalyzer
     ) {
-        $this->decoratePHPStanNodeScopeResolverWithRenamedClassSourceLocator($this->nodeScopeResolver);
     }
 
     /**
@@ -445,45 +438,4 @@ private function resolveAndSaveDependentFiles(
 
         $this->changedFilesDetector->addFileWithDependencies($filePath, $dependentFiles);
     }
-
-    /**
-     * In case PHPStan tried to parse a file with missing class, it fails.
-     * But sometimes we want to rename old class that is missing with Rector..
-     *
-     * That's why we have to skip fatal errors of PHPStan caused by missing class,
-     * so Rector can fix it first. Then run Rector again to refactor code with new classes.
-     */
-    private function decoratePHPStanNodeScopeResolverWithRenamedClassSourceLocator(
-        NodeScopeResolver $nodeScopeResolver
-    ): void {
-        // 1. get PHPStan locator
-        /** @var MemoizingReflector $classReflector */
-        $classReflector = $this->privatesAccessor->getPrivatePropertyOfClass(
-            $nodeScopeResolver,
-            'reflector',
-            Reflector::class
-        );
-
-        $reflector = $this->privatesAccessor->getPrivatePropertyOfClass(
-            $classReflector,
-            'reflector',
-            Reflector::class
-        );
-
-        /** @var SourceLocator $sourceLocator */
-        $sourceLocator = $this->privatesAccessor->getPrivatePropertyOfClass(
-            $reflector,
-            'sourceLocator',
-            SourceLocator::class
-        );
-
-        // 2. get Rector locator
-        $aggregateSourceLocator = new AggregateSourceLocator([$sourceLocator, $this->renamedClassesSourceLocator]);
-        $this->privatesAccessor->setPrivatePropertyOfClass(
-            $reflector,
-            'sourceLocator',
-            $aggregateSourceLocator,
-            AggregateSourceLocator::class
-        );
-    }
 }

phpstan-baseline.neon

@@ -132,8 +132,3 @@ parameters:
 			"""
 			count: 2
 			path: src/Rector/AbstractRector.php
-
-		-
-			message: "#^Function \"class_exists\\(\\)\" cannot be used/left in the code\\: use ReflectionProvider\\-\\>has\\*\\(\\) instead$#"
-			count: 1
-			path: src/StaticReflection/SourceLocator/RenamedClassesSourceLocator.php

rules-tests/Renaming/Rector/Name/RenameClassRector/Fixture/name_exstends_not_exists.php.inc

@@ -0,0 +1,19 @@
+<?php
+
+namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Fixture;
+
+class NameExtendsNotExists extends \NotExistsClass
+{
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\Renaming\Rector\Name\RenameClassRector\Fixture;
+
+class NameExtendsNotExists extends \NewClass
+{
+}
+
+?>

rules-tests/Renaming/Rector/Name/RenameClassRector/config/configured_rule.php

@@ -49,5 +49,6 @@
             'Doctrine\DBAL\DBALException' => 'Doctrine\DBAL\Exception',
             'Bar' => 'BarInterface',
             'App' => 'Illuminate\Support\Facades\App',
+            'NotExistsClass' => 'NewClass',
         ]);
 };