[CodeQuality] Handle mix HTML+PHP on ForRepeatedCountToOwnVariableRec…

…tor (#3282)

rules-tests/CodeQuality/Rector/For_/ForRepeatedCountToOwnVariableRector/Fixture/mix_html_php.php.inc

@@ -0,0 +1,20 @@
+<div>
+    <?php
+        for ($i = 5; $i <= count($items); $i++) {
+            echo $items[$i];
+        }
+    ?>
+</div>
+-----
+<?php
+
+?>
+<div>
+    <?php 
+$itemsCount = count($items);
+for ($i = 5; $i <= $itemsCount; $i++) {
+            echo $items[$i];
+        }
+?>
+</div>
+<?php 

src/Rector/AbstractRector.php

@@ -9,6 +9,7 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Stmt;
 use PhpParser\Node\Stmt\Expression;
+use PhpParser\Node\Stmt\InlineHTML;
 use PhpParser\Node\Stmt\Nop;
 use PhpParser\NodeTraverser;
 use PhpParser\NodeVisitor\NodeConnectingVisitor;
@@ -421,6 +422,12 @@ private function connectNodes(array $nodes, Node $node): void
         if (! $firstNodePreviousNode instanceof Node && $node->hasAttribute(AttributeKey::PREVIOUS_NODE)) {
             /** @var Node $previousNode */
             $previousNode = $node->getAttribute(AttributeKey::PREVIOUS_NODE);
+
+            if ($previousNode instanceof InlineHTML && ! $firstNode instanceof InlineHTML) {
+                // re-print InlineHTML is safe
+                $previousNode->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+            }
+
             $nodes = [$previousNode, ...$nodes];
         }
 
@@ -430,6 +437,12 @@ private function connectNodes(array $nodes, Node $node): void
         if (! $lastNodeNextNode instanceof Node && $node->hasAttribute(AttributeKey::NEXT_NODE)) {
             /** @var Node $nextNode */
             $nextNode = $node->getAttribute(AttributeKey::NEXT_NODE);
+
+            if ($nextNode instanceof InlineHTML && ! $lastNode instanceof InlineHTML) {
+                // re-print InlineHTML is safe
+                $nextNode->setAttribute(AttributeKey::ORIGINAL_NODE, null);
+            }
+
             $nodes = [...$nodes, $nextNode];
         }