[Skipper] Prevent unnecessary IO (#3664)

rectorphp · Apr 23, 2023 · dc57cff · dc57cff
1 parent 54663e7
commit dc57cff
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/packages/Skipper/RealpathMatcher.php b/packages/Skipper/RealpathMatcher.php
@@ -9,12 +9,11 @@ final class RealpathMatcher
     public function match(string $matchingPath, string $filePath): bool
     {
         $realPathMatchingPath = realpath($matchingPath);
-        $realpathFilePath = realpath($filePath);
-
         if (! is_string($realPathMatchingPath)) {
             return false;
         }
 
+        $realpathFilePath = realpath($filePath);
         if (! is_string($realpathFilePath)) {
             return false;
         }

diff --git a/packages/Skipper/SkipCriteriaResolver/SkippedPathsResolver.php b/packages/Skipper/SkipCriteriaResolver/SkippedPathsResolver.php
@@ -40,12 +40,12 @@ public function resolve(): array
                 continue;
             }
 
-            if (file_exists($value)) {
+            if (\str_contains((string) $value, '*')) {
                 $this->skippedPaths[] = $this->filePathHelper->normalizePathAndSchema($value);
                 continue;
             }
 
-            if (\str_contains((string) $value, '*')) {
+            if (file_exists($value)) {
                 $this->skippedPaths[] = $this->filePathHelper->normalizePathAndSchema($value);
             }
         }