[CodeQuality] Skip surplus open square bracket on SimplifyRegexPatter…

…nRector (#5494) * [CodeQuality] Skip surplus open square bracket on SimplifyRegexPatternRector * [CodeQuality] Skip surplus open square bracket on SimplifyRegexPatternRector
rectorphp · Jan 23, 2024 · dd02659 · dd02659
1 parent bcce8e3
commit dd02659
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/...ctor/FuncCall/SimplifyRegexPatternRector/Fixture/skip_surplus_open_square_bracket.php.inc b/...ctor/FuncCall/SimplifyRegexPatternRector/Fixture/skip_surplus_open_square_bracket.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\FuncCall\SimplifyRegexPatternRector\Fixture;
+
+class SkipSurplusOpenSquareBracket
+{
+    public function run()
+    {
+        $purln = preg_replace("/[^[a-zA-Z0-9_]/", "", "test");
+    }
+}
diff --git a/rules/CodeQuality/Rector/FuncCall/SimplifyRegexPatternRector.php b/rules/CodeQuality/Rector/FuncCall/SimplifyRegexPatternRector.php
@@ -92,6 +92,11 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            $countSqureOpenBracket = substr_count($simplifiedValue, '[');
+            if ($countSqureOpenBracket % 2 === 1) {
+                continue;
+            }
+
             $node->value = $simplifiedValue;
             return $node;
         }