Skip to content

Commit

Permalink
[Scoped] Fix build scoped on unused bin/* files in scoped build (#1491)
Browse files Browse the repository at this point in the history
* [Scoped] Exclude bin/validate-phpstan-version.php from parallel lint

* remove first

* no need exclude dependency paths as removed first

* update local script
  • Loading branch information
samsonasik committed Dec 14, 2021
1 parent 2de3a6e commit e1b44d0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_scoped_rector.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:

# 1. copy files to $NESTED_DIRECTORY directory Exclude the scoped/nested directories to prevent rsync from copying in a loop
- run: rsync --exclude rector-build -av * rector-build --quiet
- run: rm -rf rector-build/packages-tests rector-build/rules-tests rector-build/tests
- run: rm -rf rector-build/packages-tests rector-build/rules-tests rector-build/tests rector-build/bin/generate-changelog.php rector-build/bin/validate-phpstan-version.php

# 2. downgrade rector
- run: sh build/downgrade-rector.sh rector-build
Expand Down
2 changes: 0 additions & 2 deletions build/config/config-downgrade.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,6 @@ final class DowngradeRectorConfig
* Exclude paths when downgrading a dependency
*/
public const DEPENDENCY_EXCLUDE_PATHS = [
'*/bin/validate-phpstan-version.php',

'*/tests/*',
// symfony test are parts of package
'*/Test/*',
Expand Down
2 changes: 1 addition & 1 deletion full_build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ rsync --exclude rector-build -av * rector-build --quiet
# back to original composer.json
git checkout composer.json

rm -rf rector-build/packages-tests rector-build/rules-tests rector-build/tests
rm -rf rector-build/packages-tests rector-build/rules-tests rector-build/tests rector-build/bin/generate-changelog.php rector-build/bin/validate-phpstan-version.php

sh build/downgrade-rector.sh rector-build
sh build/build-rector-scoped.sh rector-build rector-prefixed-downgraded
Expand Down

0 comments on commit e1b44d0

Please sign in to comment.