[CodingStyle] Skip PreferThisOrSelfMethodCallRector to self when clas…

…s method is not static (#779)

* PreferThisOrSelfMethodCallRector should only convert static methods

* Closes #778

* add fixture for assertEquals use self

* assert equals already has fixture

Co-authored-by: Brandon Olivares <programmer2188@gmail.com>

rules-tests/CodingStyle/Rector/MethodCall/PreferThisOrSelfMethodCallRector/Fixture/skip_create_mock.php.inc

@@ -0,0 +1,15 @@
+<?php
+
+namespace Rector\Tests\CodingStyle\Rector\MethodCall\PreferThisOrSelfMethodCallRector\Fixture;
+
+use PHPUnit\Framework\TestCase;
+
+class SkipCreateMock extends TestCase
+{
+    public function test()
+    {
+        $this->createMock(\Foo::class);
+    }
+}
+
+?>

rules/CodingStyle/Rector/MethodCall/PreferThisOrSelfMethodCallRector.php

@@ -7,9 +7,11 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr\MethodCall;
 use PhpParser\Node\Expr\StaticCall;
+use PhpParser\Node\Stmt\ClassMethod;
 use PHPStan\Type\ObjectType;
 use Rector\CodingStyle\Enum\PreferenceSelfThis;
 use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
+use Rector\Core\PhpParser\AstResolver;
 use Rector\Core\Rector\AbstractRector;
 use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
 use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
@@ -36,6 +38,10 @@ final class PreferThisOrSelfMethodCallRector extends AbstractRector implements C
      */
     private array $typeToPreference = [];
 
+    public function __construct(private AstResolver $astResolver)
+    {
+    }
+
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition('Changes $this->... and static:: to self:: or vise versa for given types', [
@@ -119,6 +125,11 @@ private function processToSelf(MethodCall | StaticCall $node): ?StaticCall
             return null;
         }
 
+        $classMethod = $this->astResolver->resolveClassMethodFromCall($node);
+        if ($classMethod instanceof ClassMethod && ! $classMethod->isStatic()) {
+            return null;
+        }
+
         $name = $this->getName($node->name);
         if ($name === null) {
             return null;